Skip to content

Fix (Sanic 21.3): TypeError: sentry_router_get() takes 2 positional arguments but 4 were given #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SaidBySolo wants to merge 6 commits into from
Closed

Fix (Sanic 21.3): TypeError: sentry_router_get() takes 2 positional arguments but 4 were given #1066

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f1b931e
fix(sanic): added arguments added in sanic 21.3
SaidBySolo Mar 28, 2021
1d3ba24
fix(sanic): correct incorrect inequality sign
SaidBySolo Mar 28, 2021
f614d82
style(sanic): better code style
SaidBySolo Mar 28, 2021
92763b1
Merge branch 'getsentry:master' into sanic-integrations-fix
SaidBySolo May 14, 2021
95b48b3
Merge branch 'getsentry:master' into sanic-integrations-fix
SaidBySolo Jun 5, 2021
f6472ba
Merge branch 'getsentry:master' into sanic-integrations-fix
SaidBySolo Jun 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions sentry_sdk/integrations/sanic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,12 @@ async def sentry_handle_request(self, request, *args, **kwargs):

old_router_get = Router.get

def sentry_router_get(self, request):
# type: (Any, Request) -> Any
rv = old_router_get(self, request)
def sentry_router_get(self, request, *args):
# type: (Any, Request, Any) -> Any
if version >= (21, 3):
rv = old_router_get(self, request, *args)
else:
rv = old_router_get(self, request)
hub = Hub.current
if hub.get_integration(SanicIntegration) is not None:
with capture_internal_exceptions():
Expand Down