Support China domain in lambda cloudwatch logs url#1051
Merged
Conversation
Member
|
Is that the only region where the domain is different? |
Contributor
Author
Ah good question. It looks like AWS has three partitions: aws - I don't think we should worry about the |
Member
|
ok this makes sense. there are some failing testcases and lint jobs. Could you check them locally? CONTRIBUTING.md should contain enough info to get started. |
Contributor
Author
|
@untitaker I'm not sure why the tests are failing for python >= 3.7 for my PR, afaik my changes should not have affected this. and |
Contributor
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AWSLambdaIntegration adds the cloudwatch URL in the context but the domain is hardcoded and doesn't work for China regions.