Skip to content

Infinite loop if on-premise Sentry certificate is mismatched #788

Description

@Eugeny

If the on-premise Sentry server doesn't service the hostname anymore, the SDK will keep retrying forever while leaking RAM:

[2020-08-14 08:39:53,175] WARNING urllib3.connectionpool [pid 24849] - Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after
 connection broken by 'SSLError(SSLCertVerificationError("hostname 'sentry.xxx.com' doesn't match 'ci.xxx.com'"))': /api/2/store/
[2020-08-14 08:39:53,175] WARNING urllib3.connectionpool [pid 24847] - Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after
 connection broken by 'SSLError(SSLCertVerificationError("hostname 'sentry.xxx.com' doesn't match 'ci.xxx.com'"))': /api/2/store/
[2020-08-14 08:39:53,638]   ERROR urllib3.connection [pid 24847] - Certificate did not match expected hostname: sentry.xxx.com. Certificate: {'subject'
: ((('commonName', 'ci.xxx.com'),),), 'issuer': ((('countryName', 'US'),), (('organizationName', "Let's Encrypt"),), (('commonName', "Let's Encrypt Aut
hority X3"),)), 'version': 3, 'serialNumber': '049576F4D8FF0B1C2261AB31165FD7E910B7', 'notBefore': 'Jul 23 05:02:34 2020 GMT', 'notAfter': 'Oct 21 05:02:34
 2020 GMT', 'subjectAltName': (('DNS', 'ci.xxx.com'),), 'OCSP': ('http://ocsp.int-x3.letsencrypt.org',), 'caIssuers': ('http://cert.int-x3.letsencrypt.
org/',)}```

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions