Repository navigation
[DJANGO] Support sensitive_variables decorators in integration #2356
Description
Problem Statement
In the Django framework, a utility exists to declare that a variable is sensitive or not.
https://docs.djangoproject.com/en/3.2/_modules/django/views/decorators/debug/
Would it be possible to support this functionality in the integration directly?
Solution Brainstorm
The SDK tries to read the sensitive_variables attribute on the functions it passes to add them to sensitive information not to be displayed clearly in sentry.
Reacted by Samuel Searles-Bryant, Sarah Abderemane, Charlie Denton, 93578237 and Brian Helba
Activity
antonpirker commentedon Sep 11, 2023
Hey @ryshu thanks for bringing this up.
Sounds like a good idea. I put this on our internal backlog, but as we are a bit swamped right now it will take some time until we pick this up.
But PRs are always welcome if you want to give it a go!
ryshu commentedon Sep 13, 2023
Hello @antonpirker,
Glad to hear it.
I'm not against helping you but I currently don't know anything about the internal workings of the package and the event scrubber so I don't think I'll be of much help to you on the issue.
If you have the time to give me some keys to a possible technical solution, I could look into implementing it later.
antonpirker commentedon Sep 15, 2023
Hey @ryshu
That's fine, we just leave the issue here open and if I find some time to look into this (I also need to read some code to find out how to do this) I eventually ping you again! Thanks!
vagi8 commentedon Sep 15, 2023
Hey @antonpirker , I wanted to contribute and I have taken a look at the Django integration and Django debug sensitive variables code.
sensitive_variables_wrapper.sensitive_variables = variables,we can loop through each exception frame to check if the decorator frame exists. Then extract all sensitive variables and hide them. I was also thinking its better to hide the sensitive_variable decorator frame as well.
All these have to be implemented in
utils.serialize_framewhich is not very specific to django integration. Need some suggestions on how the implementation should be. The only way to extract the declared sensitive variables is from the decorator frame.Possible solution - we can use
mechanism.type==djangoas a way to implement specifically for django integration insideutilsbut this feels bad.13 remaining items