Repository navigation
py2.7 common CI tests green even on failure #2139
Description
How do you use Sentry?
n/a
Version
n/a
Steps to Reproduce
I recently pushed a PR with a deliberate assert False in one of the tests in test_api.py (to test #2134). The CI ran and the common py2.7 tests were still green. This might be related:
Exception in thread Thread-675:
Traceback (most recent call last):
File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/threading.py", line 801, in __bootstrap_inner
self.run()
File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/threading.py", line 754, in run
self.__target(*self.__args, **self.__kwargs)
File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/tox/session/commands/run/parallel.py", line 63, in run_in_thread
returnout=print_out,
File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/tox/action.py", line 146, in popen
reporter.quiet(output)
File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/tox/reporter.py", line 124, in quiet
self.logline_if(Verbosity.QUIET, "quiet", msg)
File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/tox/reporter.py", line 75, in logline_if
message = str(msg) if key is None else "{}{}".format(key, msg)
UnicodeEncodeError: 'ascii' codec can't encode character u'\xfc' in position 125153: ordinal not in range(128)
This is mostly a reminder for me to look into it but if someone feels like doing that themselves be my guest!
Expected Result
The tests for all environments should fail if a test fails consistently.
Actual Result
common tests for 2.7 don't fail.
Activity
[-]CI tests for py2.7 are green even if they failed[/-][+]py2.7 `common` CI tests green even on failure[/+]