Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: getsentry/sentry-python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.5.9
Choose a base ref
...
head repository: getsentry/sentry-python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.5.10
Choose a head ref
  • 5 commits
  • 6 files changed
  • 4 contributors

Commits on Apr 11, 2022

  1. Merge branch 'release/1.5.9'

    getsentry-bot committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    7d84f41 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2022

  1. Change ordering of event drop mechanisms (#1390)

    * Change ordering of event drop mechanisms
    
    As requested by @mitsuhiko this PR shall serve as basis for discussing the ordering of event drop mechanisms and its implications.
    
    We are planning for `sample_rate` to update the session counts despite dropping an event (see getsentry/develop#551 and getsentry/develop#537). Without changing the order of filtering mechanisms this would mean any event dropped by `sample_rate` would update the session even if it would be dropped by `ignore_errors` which should not update the session counts when dropping an event. By changing the order we would first drop `ignored_errors` and only then check `sample_rate`, so session counts would not be affected in the case mentioned before. The same reasoning could probably be applied to `event_processor` and `before_send` but we don't know why a developer decided to drop an event there. Was it because they don't care about the event (then session should not be updated) or to save quota (session should be updated)? Also these may be more expensive in terms of performance (developers can provide their own implementations for both of those on some SDKs). So moving them before `sample_rate` would execute `before_send` and `event_processor` for every event instead of only doing it for the sampled events.
    
    Co-authored-by: Anton Pirker <anton.pirker@sentry.io>
    adinauer and antonpirker authored Apr 12, 2022
    Configuration menu
    Copy the full SHA
    91436cd View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2022

  1. WIP: try to remove Flask version contraint (#1395)

    * Removed version constraint
    
    * Removed Flask 0.10 from test suite
    antonpirker authored Apr 14, 2022
    Configuration menu
    Copy the full SHA
    b73076b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2b1168a View commit details
    Browse the repository at this point in the history
  3. release: 1.5.10

    getsentry-bot committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    29c1b62 View commit details
    Browse the repository at this point in the history
Loading