fix(express): Support multiple routers with common paths.#6253
Merged
AbhiPrasad merged 3 commits intomasterfrom Nov 22, 2022
Merged
fix(express): Support multiple routers with common paths.#6253AbhiPrasad merged 3 commits intomasterfrom
AbhiPrasad merged 3 commits intomasterfrom
Conversation
Lms24
approved these changes
Nov 22, 2022
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
LGTM, thanks for looking into this and adding the tests! Just had one minor question.
Comment on lines
+29
to
+30
| app.use('/api', root); | ||
| app.use('/api/v1', APIv1); |
Member
There was a problem hiding this comment.
Looking at #6004, this is the order in which the parameterization was incorrect (so this is fixed, great!). Can we also verify that swapping the order still works (as the user originally reported)?
Collaborator
Author
There was a problem hiding this comment.
Added tests 👍
Contributor
size-limit report 📦
|
AbhiPrasad
approved these changes
Nov 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #6004
Handles the case when at the end of reconstruction the original URL and the reconstructed URL don't match and there are no parameters.
Added 5 integration tests that cover multiple router usage with / without parameterized routes.