feat(types): Add PolymorphicRequest type#5744
Merged
lobsterkatie merged 2 commits intomasterfrom Sep 15, 2022
Merged
Conversation
4 tasks
lobsterkatie
force-pushed
the
kmclb-add-polymorphicrequest-type
branch
from
ea549fe to
d86cd7d
Compare
Contributor
size-limit report 📦
|
lobsterkatie
force-pushed
the
kmclb-add-polymorphicrequest-type
branch
from
d86cd7d to
6b45a4d
Compare
vladanpaunovic
approved these changes
Sep 15, 2022
Contributor
vladanpaunovic
left a comment
vladanpaunovic
left a comment
There was a problem hiding this comment.
Thanks for making this more explicit.
Please fix tests and linting. Then it's good to go.
Member
Author
Yeah, of course. This is what I get for pushing right before I go to bed and not waiting for CI... I don't get a chance to fix all my dumb mistakes, LOL. |
lobsterkatie
force-pushed
the
kmclb-add-polymorphicrequest-type
branch
from
6b45a4d to
270809e
Compare
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a change which comes out of a code review of #5703, moving the
CrossPlatformTypefrom@sentry/utilsto@sentry/typesand renaming itPolymorphicRequest(to match the existingPolymorphicEvent). Because it affects a number of files, I decided to pull it into its own PR, just to not confuse things in that one.