ref: Allow to extract user IP address without req.user present#2467
ref: Allow to extract user IP address without req.user present#2467kamilogorek merged 1 commit intomasterfrom
Conversation
| event.user = { | ||
| ...event.user, | ||
| ...extractedUser, | ||
| }; |
There was a problem hiding this comment.
By doing them in this order, is it possible we'd be overwriting user data added using withScope with the extracted data?
There was a problem hiding this comment.
Yes, but this was the previous behavior and I didn't want to change it here.
There was a problem hiding this comment.
I ask because it just came up as a bug on the Python side (see getsentry/sentry-python#637). Even if we don't do it here (if we want to consider it a breaking change), might be worth thinking about as a way to prevent future user confusion/frustration.
There was a problem hiding this comment.
Agree. Let's get this in first, so it allows for extraction at all. It won't do any more harm in this form anyway.
There was a problem hiding this comment.
Created an issue so we don't forget :-)
3 participants
ref: #2462