WIP hono integration - #24371
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
size-limit report 📦
|
7b5f046 to
1e9f2bd
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 4 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1e9f2bd. Configure here.
| "test:assert:node": "RUNTIME=node pnpm test", | ||
| "test:assert:bun": "RUNTIME=bun bun run build.ts &&pnpm test", | ||
| "test:assert:deno": "RUNTIME=deno pnpm test", | ||
| "test:assert:cloudflare": "RUNTIME=cloudflare vite build && pnpm test" |
There was a problem hiding this comment.
Cloudflare tests miss Vite instrumentation
High Severity
The Cloudflare variant runs vite build then starts wrangler dev, but wrangler.jsonc still points main at src/entry.cloudflare.ts. Wrangler therefore serves the untransformed source, so sentryCloudflareVitePlugin never wraps the app or injects orchestrion channels. Auto-instrumentation on Cloudflare is not actually exercised.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 1e9f2bd. Configure here.
| @@ -1,33 +1,38 @@ | |||
| { | |||
| "name": "hono-4", | |||
| "name": "hono-4 (node)", | |||
There was a problem hiding this comment.
Invalid hono-4 package name
Medium Severity
The package name was changed from hono-4 to hono-4 (node), which is not a valid npm name (spaces/parentheses). It looks like the node variant label was pasted into name while the node variant was dropped from sentryTest.variants. That can break workspace install and makes the default (node) matrix job unlabeled.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 1e9f2bd. Configure here.
| } | ||
|
|
||
| expect(errorEventOccurred).toBe(false); | ||
| }); |
There was a problem hiding this comment.
RUNTIME branches inside single tests
Low Severity
Several new tests branch on RUNTIME (Cloudflare vs Node/Bun/Deno) inside a single test(), including different span predicates and skipped assertions. The review guidelines ask to split those paths so each runtime’s expectations fail independently rather than hiding behind an if.
Additional Locations (2)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 1e9f2bd. Configure here.
| const INTEGRATION_NAME = 'Hono' as const; | ||
|
|
||
| // oxlint-disable-next-line typescript/no-explicit-any | ||
| type HonoAny = Hono<any>; |
There was a problem hiding this comment.
Unguarded any in Hono types
Low Severity
New SDK source uses Hono<any> with only an oxlint disable and no comment explaining why a safer type is impossible. The review guidelines require that explanation on every new any.
Additional Locations (2)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 1e9f2bd. Configure here.
1 participant
TODO...