Conversation
isaacs
changed the title
|
Added a second commit to bound the number of spans that can potentially be hanging. It's a preexisting hazard that all 4 implementations had, but noticed in the refactor. If others feel like it'd be better to put off, that can be a separate issue for discussion (or ditched entirely if it's not a relevant concern), but it seemed convenient to just fix it while in the area. |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
size-limit report 📦
|
1793a3c to
19bd663
Compare
JPeer264
left a comment
JPeer264
left a comment
There was a problem hiding this comment.
It seems the react-send-to-sentry test has one record less now (not sure from just looking at the test if it is related, but it failed consistently in the CI):
- "length": 12,
+ "length": 11,
| export { growthbookIntegration } from './integrations/featureFlags'; | ||
| export { conversationIdIntegration } from './integrations/conversationId'; | ||
| export { spanStreamingIntegration } from './integrations/spanStreaming'; | ||
| export { createFetchIntegration } from './integrations/fetch'; |
There was a problem hiding this comment.
l/q: Not sure about the future of the /server export, but would it make more sense to move it to the server entrypoint instead?
There was a problem hiding this comment.
I thought that the /server and /browser endpoints in core are going away? @Lms24 didn't we have a bikeshed discussion about this somewhat recently? Or am I hallucinating that?
In the meantime, yeah, probably should be on both export paths.
Consolidate the nearly (but not exactly!) identical fetch integrations used by deno, bun, cloudflare, and vercel-edge. The functionality is placed in `@sentry/core` rather than `@sentry/server-utils` in order to avoid leaking node internals where they don't belong. closes JS-3667 closes #24344
19bd663 to
5be3ad5
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5be3ad5. Configure here.
|
@JPeer264 The react-send-to-sentry replay test is failing in the exact same way on develop, and is known flaky optional, so I think it's safe to say it's unrelated to this change. |
2 participants
Consolidate the nearly (but not exactly!) identical fetch integrations used by deno, bun, cloudflare, and vercel-edge.
The deno
breadcrumbsintegration is folded in, and the separate integration is deprecated.The functionality is placed in
@sentry/corerather than@sentry/server-utilsin order to avoid leaking node internals where they don't belong.Node and Browser fetch integrations are not touched, because they use completely different mechanisms.
closes JS-3667
closes #24344