feat(react-router): Capture server build in dev mode for middleware names#22631
Open
chargome wants to merge 1 commit into
Open
feat(react-router): Capture server build in dev mode for middleware names#22631chargome wants to merge 1 commit into
chargome wants to merge 1 commit into
Conversation
…ames Gate the server build capture Vite plugin on the transform hook's `options.ssr` flag instead of `config.build.ssr`. `options.ssr` is set for the SSR module in both `react-router dev` and production builds, so middleware names now resolve in dev mode too (previously the build-only gate skipped dev entirely). Run the instrumentation e2e app against both the production and dev servers via `TEST_ENV`, and stabilize the suite for dev mode (trailing-slash URL differences, dev-only skips for the double-instrumentation and action-error assertions). Fixes #22592 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit f8eacbf. Configure here.
chargome
marked this pull request as ready for review
July 24, 2026 14:45
chargome
requested review from
mydea and
nicohrubec
and removed request for
a team
July 24, 2026 14:45
Member
Author
|
@nicohrubec last RR pr I promise |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server build capture Vite plugin gated on
config.build.ssr, which is only true during a production build — soreact-router devnever captured the server build, and middleware names were missing in development.Gates on the
transformhook'soptions.ssrflag instead, which is set for the SSR module in both dev and production builds.To cover this, the
react-router-7-framework-instrumentatione2e app now runs against both the production server and the dev server (react-router dev) viaTEST_ENV, rather than adding a separate app. A few assertions were adjusted for dev mode: pageload/navigation URLs accept the trailing-slash difference (prod'sreact-router-serveredirects the bare index route, the dev server does not), and the double-instrumentation and action-error tests are skipped in dev (the Vite dev server serves source modules as extra requests, and the action error races the client instrumentation path).Fixes #22592