Skip to content

test(node): Disable span streaming in node-integration tests#22589

Merged
Lms24 merged 1 commit into
developfrom
test/opt-out-span-streaming-node
Jul 24, 2026
Merged

test(node): Disable span streaming in node-integration tests#22589
Lms24 merged 1 commit into
developfrom
test/opt-out-span-streaming-node

Conversation

@Lms24

@Lms24 Lms24 commented Jul 24, 2026

Copy link
Copy Markdown
Member

Prework for enabling span streaming by default without breaking existing Node integration tests.

These tests explicitly stay on the static trace lifecycle for now. This is the node-integration-tests slice of #22577 and is independent of the other split PRs.

Refs #22344

Made with Cursor

Keep transaction-asserting Node integration tests on the static trace
lifecycle while span streaming is enabled by default.

Refs #22344
Co-Authored-By: Cursor <cursoragent@cursor.com>

Co-authored-by: Cursor <cursoragent@cursor.com>
@Lms24 Lms24 changed the title test(node): Disable span streaming in integration tests test(node): Disable span streaming in node-integration tests Jul 24, 2026
@Lms24
Lms24 marked this pull request as ready for review July 24, 2026 14:48
@Lms24
Lms24 requested a review from a team as a code owner July 24, 2026 14:48
@Lms24
Lms24 requested review from andreiborza and isaacs and removed request for a team July 24, 2026 14:48

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test changed slightly due to the new option requiring one extra line in init. hence frame context lines changed

@Lms24 Lms24 self-assigned this Jul 24, 2026
@Lms24
Lms24 merged commit 95429cd into develop Jul 24, 2026
81 of 90 checks passed
@Lms24
Lms24 deleted the test/opt-out-span-streaming-node branch July 24, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants