build(oxlint): upgrade oxlint to 1.75 and tsgolint to TS 7#22561
Draft
logaretm wants to merge 6 commits into
Draft
build(oxlint): upgrade oxlint to 1.75 and tsgolint to TS 7#22561logaretm wants to merge 6 commits into
logaretm wants to merge 6 commits into
Conversation
Contributor
size-limit report 📦
|
logaretm
force-pushed
the
awad/upgrade-oxlint
branch
from
July 23, 2026 16:20
02b93b1 to
af518ac
Compare
logaretm
force-pushed
the
awad/ts7-tsconfig-fixes
branch
from
July 23, 2026 16:49
838479d to
07876d0
Compare
logaretm
force-pushed
the
awad/upgrade-oxlint
branch
from
July 23, 2026 16:49
af518ac to
977d8d4
Compare
logaretm
force-pushed
the
awad/upgrade-oxlint
branch
from
July 23, 2026 17:06
977d8d4 to
d5565e9
Compare
logaretm
commented
Jul 23, 2026
| // If we have no comparison branch, we just run size limit & store the result as artifact | ||
| if (!comparisonBranch) { | ||
| return runSizeLimitOnComparisonBranch(); | ||
| return await runSizeLimitOnComparisonBranch(); |
Member
Author
There was a problem hiding this comment.
Example of the new return await rule detecting returning promises inside try/catch blocks.
Renames/drops the rules the new versions flag as unknown: `no-return-await` becomes `typescript/return-await` (kept on the modern in-try-catch default), and rules removed upstream are dropped since they no longer exist natively: `quotes` (now owned by oxfmt), `import/no-unresolved` (was off everywhere), `import/no-extraneous-dependencies`, `jsdoc/require-jsdoc`, and `react/prop-types`. Also removes the `OXLINT_TSGOLINT_DANGEROUSLY_SUPPRESS_PROGRAM_DIAGNOSTICS` workaround from every lint script so tsgolint surfaces real program diagnostics again.
Clears the type-aware errors that appeared once real program diagnostics were re-enabled: - Removes unnecessary type assertions and the now-unused type imports they leave behind (oxlint --fix), and drops a dead pino integration interface. - Consolidates the dedupe stacktrace/fingerprint guards so narrowing works without the old assignment-cast idiom. - Migrates the terser plugin from the deprecated `output` option to `format`. - Renames stale disable directives to the new rule names (`typescript-eslint(...)` -> `typescript/...`) for unbound-method and the HTTP_URL no-deprecated suppressions. - Adds no-deprecated suppressions where we intentionally read our own deprecated options for back-compat, and return-await suppressions where an await is deliberate (node-cron) or the cast makes the rule misfire.
…ssary `no-unnecessary-type-assertion` (tsgolint) reports several casts as redundant, but they are load-bearing: it only checks assignability at the cast site and misses that the cast changes the expression's resulting type for downstream use. Removing them type-checks locally but fails the real `tsc` build (verified: both tsconfig.json and tsconfig.types.json error identically without the cast). Restores each cast with a targeted suppression: a Cloudflare-only client option, LCP/INP PerformanceEntry fields, a Vue VNode probe, mysql/postgres vendored connection shapes, the view-hierarchy identifier, and the internal `shouldNotThrowOnFailure` on setCommits. eventbuilder instead uses a typed `Exception` variable so no cast (or suppression) is needed there.
The oxlint 1.75 bump surfaced ~5.9k warnings. This clears them to zero without churning the codebase: - Vitest: keep the plugin (and its ~60 other rules) but disable the correctness rules the bump newly fired across the existing suite (no-standalone-expect, require-mock-type-parameters, no-conditional-expect, expect-expect, valid-title, valid-expect, require-to-throw-message, no-disabled-tests, valid-describe-callback). - Disable rules that over-trigger / false-positive here: no-useless-default-assignment, no-useless-fallback-in-spread, no-thenable (we implement thenables), no-new-array (used with immediate .fill()), prefer-string-starts-ends-with. - Keep no-empty-file on (catches accidental empties) but exempt the two intentional comment-only files, and silence test-file occurrences of the general rules. - Fix the few worth fixing: drop redundant `void` operators in the graphql/firebase channel callbacks, type the bun test-runner fetch init as RequestInit, and suppress the two no-unreachable false positives in rollup dual-build helpers. Note: vitest/valid-expect flagged 10 pre-existing broken tests (chai-style `.to.` modifiers); left for a separate fix.
…base
The develop rebase reintroduced the OTel span casts (its span-kind refactor
touched this file); tsgolint flags them as unnecessary again, so drop them
while keeping develop's `attributes ... || {}` change.
waitForReplayEventBuffer hardcoded "one Promise.resolve() per await in the util functions", so it silently coupled the test to the enrichment chain's exact await count. That made a behavior-neutral lint fix (dropping a redundant `return await` in _getResponseText) look like a data-loss regression. Flush microtasks in a bounded loop instead, so the test no longer depends on the implementation's await depth. _getResponseText keeps the rule-compliant `return response.text()`.
logaretm
force-pushed
the
awad/upgrade-oxlint
branch
from
July 23, 2026 18:41
d5565e9 to
5da364a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades oxlint (1.53 to 1.75) and oxlint-tsgolint (0.16 to 7, now on TS 7), and removes the
OXLINT_TSGOLINT_DANGEROUSLY_SUPPRESS_PROGRAM_DIAGNOSTICSworkaround from every lint script so real type-aware diagnostics run again.quotesis oxfmt's job now,import/no-unresolved,import/no-extraneous-dependencies,jsdoc/require-jsdoc,react/prop-types).no-return-awaitbecomestypescript/return-await.Also ignores some new rules like
unicornthat introduced a bunch of warnings, I see some useful stuff in there so I may re-enable them one by one later.One of the changes surfaced a very flakey test that relies on a microtick timing, i padded it to make it more reliable.