ref: Deprecate top-level stacktrace by kamilogorek · Pull Request #2214 · getsentry/sentry-javascript

kamilogorek · 2019-08-26T10:06:02Z

getsentry-bot · 2019-08-26T10:11:54Z

	Fails
🚫	TSLint failed: @sentry/core ERROR: /home/travis/build/getsentry/sentry-javascript/packages/core/src/integrations/inboundfilters.ts[164, 17]: stacktrace is deprecated: Top-level `stacktrace` attribute has been deprecated. Use event.threads.0.stacktrace instead. See https://docs.sentry.io/development/sdk-dev/event-payloads/stacktrace/ for more informations. ERROR: /home/travis/build/getsentry/sentry-javascript/packages/integrations/src/dedupe.ts[100, 22]: stacktrace is deprecated: Top-level `stacktrace` attribute has been deprecated. Use event.threads.0.stacktrace instead. See https://docs.sentry.io/development/sdk-dev/event-payloads/stacktrace/ for more informations. ERROR: /home/travis/build/getsentry/sentry-javascript/packages/integrations/src/dedupe.ts[101, 20]: stacktrace is deprecated: Top-level `stacktrace` attribute has been deprecated. Use event.threads.0.stacktrace instead. See https://docs.sentry.io/development/sdk-dev/event-payloads/stacktrace/ for more informations.
🚫	TSLint failed: @sentry/integrations ERROR: /home/travis/build/getsentry/sentry-javascript/packages/integrations/src/dedupe.ts[100, 22]: stacktrace is deprecated: Top-level `stacktrace` attribute has been deprecated. Use event.threads.0.stacktrace instead. See https://docs.sentry.io/development/sdk-dev/event-payloads/stacktrace/ for more informations. ERROR: /home/travis/build/getsentry/sentry-javascript/packages/integrations/src/dedupe.ts[101, 20]: stacktrace is deprecated: Top-level `stacktrace` attribute has been deprecated. Use event.threads.0.stacktrace instead. See https://docs.sentry.io/development/sdk-dev/event-payloads/stacktrace/ for more informations. ERROR: /home/travis/build/getsentry/sentry-javascript/packages/integrations/src/rewriteframes.ts[82, 22]: stacktrace is deprecated: Top-level `stacktrace` attribute has been deprecated. Use event.threads.0.stacktrace instead. See https://docs.sentry.io/development/sdk-dev/event-payloads/stacktrace/ for more informations. ERROR: /home/travis/build/getsentry/sentry-javascript/packages/integrations/src/rewriteframes.ts[83, 20]: stacktrace is deprecated: Top-level `stacktrace` attribute has been deprecated. Use event.threads.0.stacktrace instead. See https://docs.sentry.io/development/sdk-dev/event-payloads/stacktrace/ for more informations. ERROR: /home/travis/build/getsentry/sentry-javascript/packages/integrations/test/rewriteframes.test.ts[50, 20]: stacktrace is deprecated: Top-level `stacktrace` attribute has been deprecated. Use event.threads.0.stacktrace instead. See https://docs.sentry.io/development/sdk-dev/event-payloads/stacktrace/ for more informations. ERROR: /home/travis/build/getsentry/sentry-javascript/packages/integrations/test/rewriteframes.test.ts[51, 20]: stacktrace is deprecated: Top-level `stacktrace` attribute has been deprecated. Use event.threads.0.stacktrace instead. See https://docs.sentry.io/development/sdk-dev/event-payloads/stacktrace/ for more informations. ERROR: /home/travis/build/getsentry/sentry-javascript/packages/integrations/test/rewriteframes.test.ts[70, 20]: stacktrace is deprecated: Top-level `stacktrace` attribute has been deprecated. Use event.threads.0.stacktrace instead. See https://docs.sentry.io/development/sdk-dev/event-payloads/stacktrace/ for more informations. ERROR: /home/travis/build/getsentry/sentry-javascript/packages/integrations/test/rewriteframes.test.ts[71, 20]: stacktrace is deprecated: Top-level `stacktrace` attribute has been deprecated. Use event.threads.0.stacktrace instead. See https://docs.sentry.io/development/sdk-dev/event-payloads/stacktrace/ for more informations. ERROR: /home/travis/build/getsentry/sentry-javascript/packages/integrations/test/rewriteframes.test.ts[93, 20]: stacktrace is deprecated: Top-level `stacktrace` attribute has been deprecated. Use event.threads.0.stacktrace instead. See https://docs.sentry.io/development/sdk-dev/event-payloads/stacktrace/ for more informations. ERROR: /home/travis/build/getsentry/sentry-javascript/packages/integrations/test/rewriteframes.test.ts[94, 20]: stacktrace is deprecated: Top-level `stacktrace` attribute has been deprecated. Use event.threads.0.stacktrace instead. See https://docs.sentry.io/development/sdk-dev/event-payloads/stacktrace/ for more informations. ERROR: /home/travis/build/getsentry/sentry-javascript/packages/integrations/test/rewriteframes.test.ts[95, 20]: stacktrace is deprecated: Top-level `stacktrace` attribute has been deprecated. Use event.threads.0.stacktrace instead. See https://docs.sentry.io/development/sdk-dev/event-payloads/stacktrace/ for more informations. ERROR: /home/travis/build/getsentry/sentry-javascript/packages/integrations/test/rewriteframes.test.ts[96, 20]: stacktrace is deprecated: Top-level `stacktrace` attribute has been deprecated. Use event.threads.0.stacktrace instead. See https://docs.sentry.io/development/sdk-dev/event-payloads/stacktrace/ for more informations.

	Messages
📖	@sentry/browser bundle gzip'ed minified size: ($ cat build/bundle.min.js \| gzip -9 \| wc -c \| awk '{$1=$1/1024; print "ES5: ",$1,"kB";}') (ES5: 16.2051 kB)

Generated by 🚫 dangerJS against d93aa12

HazAT · 2019-08-26T10:36:26Z

@jan-auer Probably not you but can we tell the Sentry UI to not show the thread selector in case of only one thread?
Some ppl will find this strange in JS.

HazAT · 2019-08-26T10:38:39Z

  extra?: { [key: string]: any };
  user?: User;
  type?: EventType;
+  threads?: Thread[];


Please add a @deprecated Use event.threads.0.stacktrace comment to stacktrace.

HazAT · 2019-08-26T10:40:11Z

              return;
            }

+            if ('stacktrace' in finalEvent) {


I would remove this, just bloats up the bundle size.
If we deprecate the property in TS in the type it's enough.

jan-auer · 2019-08-26T11:03:58Z

@HazAT @kamilogorek can you test with this please?
getsentry/sentry#14503

kamilogorek · 2019-08-27T12:35:59Z

@HazAT done

This reverts commit 36d206c.

kamilogorek requested a review from HazAT August 26, 2019 10:06

kamilogorek force-pushed the deprecate-stacktrace branch from 7f61956 to f1fdc70 Compare August 26, 2019 10:21

HazAT requested changes Aug 26, 2019

View reviewed changes

kamilogorek force-pushed the deprecate-stacktrace branch from f1fdc70 to d93aa12 Compare August 27, 2019 12:34

kamilogorek added 2 commits August 29, 2019 13:58

ref: Deprecate top-level stacktrace

1b9c9db

Moar tests

7d995cb

kamilogorek force-pushed the deprecate-stacktrace branch from 20ea674 to 7d995cb Compare August 29, 2019 11:58

kamilogorek merged commit 36d206c into master Aug 29, 2019

kamilogorek deleted the deprecate-stacktrace branch August 29, 2019 12:01

kamilogorek restored the deprecate-stacktrace branch August 29, 2019 12:52

kamilogorek added a commit that referenced this pull request Aug 29, 2019

Revert "ref: Deprecate top-level stacktrace (#2214)"

76644bf

This reverts commit 36d206c.

kamilogorek deleted the deprecate-stacktrace branch October 21, 2020 09:56

Navigation Menu

Uh oh!

Uh oh!

ref: Deprecate top-level stacktrace - #2214

ref: Deprecate top-level stacktrace#2214
kamilogorek merged 2 commits into
masterfrom
deprecate-stacktrace

kamilogorek commented Aug 26, 2019

Uh oh!

getsentry-bot commented Aug 26, 2019 •

edited

Loading

Uh oh!

HazAT commented Aug 26, 2019

Uh oh!

HazAT Aug 26, 2019

Uh oh!

HazAT Aug 26, 2019

Uh oh!

jan-auer commented Aug 26, 2019

Uh oh!

kamilogorek commented Aug 27, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

kamilogorek commented Aug 26, 2019

Uh oh!

getsentry-bot commented Aug 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HazAT commented Aug 26, 2019

Uh oh!

HazAT Aug 26, 2019

Choose a reason for hiding this comment

Uh oh!

HazAT Aug 26, 2019

Choose a reason for hiding this comment

Uh oh!

jan-auer commented Aug 26, 2019

Uh oh!

kamilogorek commented Aug 27, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

getsentry-bot commented Aug 26, 2019 •

edited

Loading