fix(replays): Record replay trace_ids with span streaming#21714
Merged
Conversation
Contributor
size-limit report 📦
|
mjq
force-pushed
the
mjq/span-streaming-replay-traceids
branch
from
614abab to
f20f909
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
mjq
requested review from
Lms24,
logaretm and
mydea
and removed request for
a team
logaretm
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replay events'
trace_idsproperty is currently only set inhandleTransactionEvent:sentry-javascript/packages/replay-internal/src/coreHandlers/handleAfterSendEvent.ts
Lines 34 to 43 in 1dfd682
This never fires when span streaming is enabled, as we no longer emit transaction events. As a consequence, replays'
trace_idslist is always empty under span streaming.Add another equivalent hook on
afterSegmentSpanEndto recordtrace_idswhen span streaming is enabled.Only sampled spans are considered, which matches the previous behaviour for transactions.
🤖: Claude/Opus 4.6 did a first pass and then I refactored it into shape. Claude wrote the tests though (looked fine to me).