cc @Lms24 this is what we want for span streaming, but I guess kind of breaking...? do we care...?

Yeah, let's only add the attribute (this is a good thing IMO and can happen ASAP).

Let's hold off from making span name changes just yet. Talked about this with @cleptric when I worked on #21599. We'll very likely need to dynamcially decide what span name to set depending on span streaming enabled/disabled.

Removed it from postgres. I still like to add this for #21656, though.

INSERT misreads SELECT in strings

Medium Severity

For INSERT statements, the follow-up scan uses a word-boundary SELECT match on the remainder of the query after the target table. That can match SELECT inside quoted string literals in VALUES clauses, so plain INSERT ... VALUES (...) queries may be summarized like INSERT ... SELECT ... with extra tokens from extractTableNames, skewing db.query.summary cardinality.

 

^{Reviewed by Cursor Bugbot for commit e94685f. Configure here.}

Whitespace-only query mishandled

Low Severity

getSqlQuerySummary returns undefined for '' but not for strings that contain only whitespace. Those inputs fall through to the fallback, which can yield a non-empty whitespace string instead of undefined, unlike the empty-string case.

 

^{Reviewed by Cursor Bugbot for commit 34b5ca7. Configure here.}