feat: Remove Otel from fsIntegration #21654
Merged
Merged
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Member
Ah, simpler (better?) times... |
nicohrubec
reviewed
Jun 22, 2026
| recordErrorMessagesAsSpanAttributes: options.recordErrorMessagesAsSpanAttributes, | ||
| }), | ||
| )(); | ||
| if (options.enabled === false) return; |
Member
There was a problem hiding this comment.
m: Do we need to expose an enabled flag? Afaik we don't have such a flag for other instrumentations and not sure if we need it given that the integration needs to be explicitly added
Collaborator
Author
There was a problem hiding this comment.
Ah, because I removed InstrumentationConfig I assumed we needed to retain the enabled to make the change non-breaking but it wasn't exported!
nicohrubec
reviewed
Jun 22, 2026
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@opentelemetry/instrumentation-fsto orchestrion #20750This PR doesn't actually use orchestrion.
Becuase
fsin a Node built-in, it is CJS and can therfore be monkey patched like it's 2005.