fix(tanstackstart-react): Preserve middleware context types#21441
Open
andreiborza wants to merge 1 commit into
Open
fix(tanstackstart-react): Preserve middleware context types#21441andreiborza wants to merge 1 commit into
andreiborza wants to merge 1 commit into
Conversation
The global middlewares were types as `TanStackMiddlewareBase` with `~types:
any`. TSS merges these context types, folding over all contexts ending up with
types that cary over, .e.g
```js
{
[x: string]: any;
[x: number]: any;
[x: symbol]: any;
db: { query: (sql: string) => Promise<string[]> };
}
```
We now mirror TSS's middleware types instead with all contexct and validator
fields set to `undefined`, which is what a context-free middleware resolves to.
Note: We use both the newer `~types` and the older `_types` to be compatible
with our supported TSS range.
Fixes: #21433
andreiborza
requested review from
chargome and
nicohrubec
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The global middlewares were types as
TanStackMiddlewareBasewith~types: any. TSS merges these context types, folding over all contexts ending up with types that cary over, .e.gWe now mirror TSS's middleware types instead with all contexct and validator fields set to
undefined, which is what a context-free middleware resolves to.Note: We use both the newer
~typesand the older_typesto be compatible with our supported TSS range.Pre-fix:
Post-fix:
Fixes: #21433