ref(node): Drop eslint-ignores and oxlint exemption in generic-pool instrumentation#21435
Merged
Merged
Conversation
Type the one remaining `any` (the vendored Pool index signature) as `unknown` and remove generic-pool from the no-explicit-any override in .oxlintrc.base.json. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Replace the three `const instrumentation = this` aliases with captured tracer/bound methods/an arrow over the live `_isDisabled` flag, so no eslint-disable is needed. Only true false-positives keep suppressions. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nicohrubec
changed the title
nicohrubec
requested review from
JPeer264 and
andreiborza
and removed request for
a team
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the vendored-instrumentation streamlining removing some eslint ignores and the oxlint exemption.