ref(nestjs): Streamline nestjs-core#21434
Draft
nicohrubec wants to merge 4 commits into
Draft
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Adds a 'Sends an app_creation transaction' test to nestjs-basic for the `Create Nest App` span (NestFactory.create), which had no coverage. It's a boot-time transaction, so it uses a look-back envelope wait. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nicohrubec
force-pushed
the
nh/streamline-nestjs-core
branch
from
9aa697e to
9ffb469
Compare
The vendored `semconv.ts` only held `http.method`/`http.url` string literals, carried over with upstream's "@deprecated, use http.request.method/url.full" notices. Sentry deliberately uses the old HTTP conventions, so those notices are misleading. Inline the two literals and drop the file + import. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Restore the vendored `Controller`/`NestFactory`/`RouterExecutionContext` type stubs from upstream (just swapping `any` for `unknown`) rather than replacing them with custom interfaces. Keeps the vendored file closer to upstream for easier re-vendoring. Type-only change; emitted JS is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streamlines the vendored
@opentelemetry/instrumentation-nestjs-core:OTEL_SEMCONV_STABILITY_OPT_INdual-emission path and always emits the oldhttp.method/http.urlattributes, aligning with the conventions Sentry emits everywhere else (the SDK never read the stable ones).PIPES/INTERCEPTORS/GUARDS)./* eslint-disable */and theno-explicit-anyoverride exemption — the vendored code is now properly typed instead (noany, no suppressions).No metrics to strip (span-only). Upstream's only unit test is integration-style (real Nest app), already covered by the nestjs e2e suite, so no unit-test port.
Fixes #20945
🤖 Generated with Claude Code