chore(deps): Upgrade @remix-run deps to 2.17.4#19040
Merged
Conversation
chargome
approved these changes
Jan 28, 2026
onurtemizkan
approved these changes
Jan 28, 2026
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
| "react": "^18.3.1", | ||
| "react-dom": "^18.3.1", | ||
| "vite": "^5.4.11" | ||
| "vite": "^6.0.0" |
There was a problem hiding this comment.
Bug: Upgrading vite to ^6.0.0 violates the peerDependency of @remix-run/dev@2.17.4, which requires vite: ^5.1.0.
Severity: MEDIUM
Suggested Fix
To resolve the peer dependency conflict, either downgrade vite to a version compatible with @remix-run/dev@2.17.4 (e.g., ^5.x.x), or wait until @remix-run/dev is updated to officially support vite@6.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: packages/remix/package.json#L85
Potential issue: The project upgrades `vite` to version `^6.0.0` while still using
`@remix-run/dev@2.17.4`. The `@remix-run/dev` package specifies a `peerDependency` on
`vite: ^5.1.0`, which translates to versions greater than or equal to 5.1.0 but less
than 6.0.0. This version mismatch violates the peer dependency constraint, which will
cause package managers to generate warnings or errors during installation. As Vite 6.0.0
is a major version with breaking changes, there is also a risk of runtime failures if
the Remix Vite plugin is incompatible.
Did we get this right? 👍 / 👎 to inform future reviews.
This was referenced Jan 29, 2026
This was referenced Jan 30, 2026
This was referenced Feb 1, 2026
This was referenced Feb 2, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/getsentry/sentry-javascript/security/dependabot/915
Closes https://github.com/getsentry/sentry-javascript/security/dependabot/912
Closes https://github.com/getsentry/sentry-javascript/security/dependabot/908
Closes https://github.com/getsentry/sentry-javascript/security/dependabot/907
Closes https://github.com/getsentry/sentry-javascript/security/dependabot/904
Closes #19041 (added automatically)