ref(node): Remove duplicate function isCjs#18662
Merged
Conversation
timfish
approved these changes
Jan 2, 2026
andreiborza
approved these changes
Jan 2, 2026
Member
andreiborza
left a comment
andreiborza
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up!
JPeer264
approved these changes
Jan 2, 2026
Lms24
approved these changes
Jan 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on something else I stumbled over this unused, duplicated function. Also, there was still one implementation in Google Cloud Serverless, which checked for
typeof require !== 'undefined', which does not work well all the time (see this PR: #15927).Closes #18663 (added automatically)