feat(core): Add consoleLoggingIntegration for logs#15955
Merged
AbhiPrasad merged 3 commits intodevelopfrom Apr 3, 2025
Merged
Conversation
AbhiPrasad
requested review from
mydea and
s1gr1d
and removed request for
a team
there are some cases where this breaks badly
onurtemizkan
pushed a commit
that referenced
this pull request
Apr 3, 2025
Adds `consoleLoggingIntegration` integration that takes calls to
`console.X` and flushes them as logs. For now this is an opt-in
integration. We can evaluate it's default status at a later point.
```js
import * as Sentry from '@sentry/browser'; // or any other supported sdk
Sentry.init({
// send console.log, console.error, and console.warn calls as logs to Sentry
integrations: [Sentry.consoleLoggingIntegration({ levels: ['log', 'error', 'warn'] })],
});
```
## Notes
In general we have inconsistencies with console instrumentation across
our different SDKs.
- In browser we have console instrumentation as part of the
`Breadcrumbs` integration.
- In node we have console instrumentation that generates breadcrumbs in
the `Console` integration
- In core we have console instrumentation, which generates errors and
messages via the `CaptureConsole` integration
For now because logs are experimental, making it a standalone
integration feels fine to me. As we get closer to GA status for logs
(and there is a distinct path for breadcrumbs) we should evaluate how
all of our console integrations are structured.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #15917
previous attempt: #15828
Adds
consoleLoggingIntegrationintegration that takes calls toconsole.Xand flushes them as logs. For now this is an opt-in integration. We can evaluate it's default status at a later point.Notes
In general we have inconsistencies with console instrumentation across our different SDKs. #4532.
Breadcrumbsintegration.ConsoleintegrationCaptureConsoleintegrationFor now because logs are experimental, making it a standalone integration feels fine to me. As we get closer to GA status for logs (and there is a distinct path for breadcrumbs) we should evaluate how all of our console integrations are structured.