ref(flags): support single-client tracking in OpenFeatureIntegration#14838
Closed
aliu39 wants to merge 8 commits into
Closed
ref(flags): support single-client tracking in OpenFeatureIntegration#14838aliu39 wants to merge 8 commits into
aliu39 wants to merge 8 commits into
Conversation
2 tasks
This reverts commit a35e2b9.
aliu39
marked this pull request as draft
January 6, 2025 16:49
billyvg
removed their request for review
January 8, 2025 18:19
Member
Author
|
We have to rethink this since we decided to prioritize global tracking. The user's setup code could still be simplified, but prioritizing other FF work for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14645
By un-exporting the Hook, this will simplify setup for users.
The decision to track a single client is something we're doing across all FF integrations. From getsentry/sentry-python#3895:
Updated setup code can be seen at: https://github.com/getsentry/sentry-docs/pull/12222/files
Todo: