feat(spotlight): Extract SpotlightIntegration to separate module by romtsn · Pull Request #5064 · getsentry/sentry-java

romtsn · 2026-01-28T22:00:15Z

📜 Description

Move SpotlightIntegration to a new sentry-spotlight module to allow
excluding it from release builds, preventing insecure HTTP URLs from
appearing in APKs and triggering security scanner warnings.

This change:

Creates new sentry-spotlight module with SpotlightIntegration
Uses reflection-based loading in SentryOptions to conditionally
load SpotlightIntegration when the module is available
Adds AndroidManifest support for Spotlight configuration via
io.sentry.spotlight.enabled and io.sentry.spotlight.url
Removes hardcoded fallback URL from OtelInternalSpanDetectionUtil
Makes NoOpSentryExecutorService public with @Internal annotation
Registers sentry-spotlight package in SentryIntegrationPackageStorage

Breaking Change: Users who enable Spotlight must now add the
io.sentry:sentry-spotlight dependency to their project.

💡 Motivation and Context

Fixes #3259
Fixes #3690

💚 How did you test it?

Existing tests

📝 Checklist

I added GH Issue ID & Linear ID
I added tests to verify the changes.
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
I updated the docs if needed.
I updated the wizard if needed.
Review from the native team if needed.
[] No breaking change or entry added to the changelog.
No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Release new package
Add it to release registry
Update .craft.yml to get auto-releases
Update README with the new package
Update docs

github-actions · 2026-01-28T22:00:41Z

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

New Features ✨

(distribution) Add install_groups support by runningcode in #5062

(spotlight) Extract SpotlightIntegration to separate module by romtsn in #5064

Bug Fixes 🐛

Establish native exception mechanisms by supervacuus in #5052

Internal Changes 🔧

Deps

Bump urllib3 from 2.6.0 to 2.6.3 in the pip group across 1 directory by dependabot in #5003
Update Native SDK to v0.12.4 by github-actions in #5061
Bump getsentry/github-workflows/.github/workflows/updater.yml from 2 to 3 by dependabot in #4884
Bump actions/cache from 4 to 5 by dependabot in #4997
Bump github/codeql-action from 4.31.10 to 4.31.11 by dependabot in #5057
Bump getsentry/craft from 2.19.0 to 2.20.0 by dependabot in #5058

Other

(android) Update targetSdk to API 36 (Android 16) by markushi in #5016
(ci) Write permission for statuses in changelog preview by supervacuus in #5053
(samples) Convert main screen to Jetpack Compose by markushi in #5017

_{🤖 This preview updates automatically when you update the PR.}

github-actions · 2026-01-28T22:00:45Z

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 9d9efad

...-opentelemetry-core/src/main/java/io/sentry/opentelemetry/OtelInternalSpanDetectionUtil.java

sentry-spotlight/src/main/java/io/sentry/spotlight/SpotlightIntegration.java

sentry-spotlight/src/test/java/io/sentry/util/SpotlightPlatformTestManipulator.kt

github-actions · 2026-01-28T22:11:08Z

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	336.82 ms	382.19 ms	45.37 ms
Size	1.58 MiB	2.19 MiB	619.17 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`fc5ccaf`	322.49 ms	405.25 ms	82.76 ms
`e59e22a`	329.74 ms	383.31 ms	53.57 ms
`ae7fed0`	293.84 ms	380.22 ms	86.38 ms
`fcec2f2`	314.96 ms	373.66 ms	58.70 ms
`dba088c`	320.59 ms	361.29 ms	40.70 ms
`b03edbb`	314.90 ms	350.22 ms	35.33 ms
`ee747ae`	358.21 ms	389.41 ms	31.20 ms
`b6702b0`	395.86 ms	409.98 ms	14.12 ms
`fcec2f2`	328.91 ms	387.75 ms	58.84 ms
`dcc6bbf`	382.58 ms	462.13 ms	79.54 ms

App size

Revision	Plain	With Sentry	Diff
`fc5ccaf`	1.58 MiB	2.13 MiB	557.54 KiB
`e59e22a`	1.58 MiB	2.20 MiB	635.34 KiB
`ae7fed0`	1.58 MiB	2.12 MiB	551.77 KiB
`fcec2f2`	1.58 MiB	2.12 MiB	551.50 KiB
`dba088c`	1.58 MiB	2.13 MiB	558.99 KiB
`b03edbb`	1.58 MiB	2.13 MiB	557.32 KiB
`ee747ae`	1.58 MiB	2.10 MiB	530.95 KiB
`b6702b0`	1.58 MiB	2.12 MiB	551.79 KiB
`fcec2f2`	1.58 MiB	2.12 MiB	551.50 KiB
`dcc6bbf`	1.58 MiB	2.12 MiB	553.10 KiB

Previous results on branch: rz/fix/spotlight-insecure-url

Startup times

Revision	Plain	With Sentry	Diff
`c69dea4`	274.93 ms	334.36 ms	59.43 ms
`01f0c4b`	311.54 ms	366.76 ms	55.21 ms
`e3de960`	320.22 ms	388.88 ms	68.66 ms
`76153f6`	307.83 ms	352.64 ms	44.81 ms

App size

Revision	Plain	With Sentry	Diff
`c69dea4`	1.58 MiB	2.19 MiB	619.18 KiB
`01f0c4b`	1.58 MiB	2.19 MiB	619.16 KiB
`e3de960`	1.58 MiB	2.19 MiB	619.17 KiB
`76153f6`	1.58 MiB	2.19 MiB	619.17 KiB

sentry-spotlight/src/main/java/io/sentry/spotlight/SpotlightIntegration.java

CHANGELOG.md

Co-authored-by: Markus Hintersteiner <markus.hintersteiner@sentry.io>

sentry/src/main/java/io/sentry/SentryOptions.java

sentry-samples/sentry-samples-android/build.gradle.kts

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

sentry/src/main/java/io/sentry/SentryOptions.java

## DESCRIBE YOUR PR Add documentation for the new `sentry-spotlight` module extracted in [sentry-java#5064](getsentry/sentry-java#5064) (available from 8.32.0). This module allows Android users to include Spotlight only in debug builds via `debugImplementation`, preventing insecure HTTP URLs from leaking into production APKs. - Add Android Spotlight integration page (`/platforms/android/integrations/spotlight/`) with AndroidManifest.xml and programmatic configuration - Add Java Spotlight integration page (`/platforms/java/integrations/spotlight/`) with Gradle, Maven, and SBT install snippets ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.):  - [ ] Other deadline:  - [x] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) --------- Co-authored-by: Claude <noreply@anthropic.com>

romtsn requested review from adinauer, lcian and markushi as code owners January 28, 2026 22:00

sentry bot reviewed Jan 28, 2026

View reviewed changes

...-opentelemetry-core/src/main/java/io/sentry/opentelemetry/OtelInternalSpanDetectionUtil.java Outdated Show resolved Hide resolved

cursor bot reviewed Jan 28, 2026

View reviewed changes

sentry-spotlight/src/main/java/io/sentry/spotlight/SpotlightIntegration.java Show resolved Hide resolved

sentry-spotlight/src/test/java/io/sentry/util/SpotlightPlatformTestManipulator.kt Show resolved Hide resolved

romtsn added 2 commits January 28, 2026 23:18

feat(spotlight): Extract SpotlightIntegration to separate module

3e7761c

Changelog

f93665c

romtsn force-pushed the rz/fix/spotlight-insecure-url branch from c000776 to f93665c Compare January 28, 2026 22:20

cursor bot reviewed Jan 28, 2026

View reviewed changes

sentry-spotlight/src/main/java/io/sentry/spotlight/SpotlightIntegration.java Show resolved Hide resolved

romtsn added 2 commits January 28, 2026 23:46

Address review

6da1532

Merge branch 'main' into rz/fix/spotlight-insecure-url

f01bb00

cursor bot reviewed Jan 28, 2026

View reviewed changes

sentry-spotlight/src/main/java/io/sentry/spotlight/SpotlightIntegration.java Show resolved Hide resolved

Api dump

d55fab3

markushi approved these changes Jan 29, 2026

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

romtsn and others added 3 commits January 29, 2026 12:16

Update CHANGELOG.md

fe1a2a8

Co-authored-by: Markus Hintersteiner <markus.hintersteiner@sentry.io>

Enable spotlight in the sample app

7b1e27b

Merge branch 'main' into rz/fix/spotlight-insecure-url

6b376dc

sentry bot reviewed Jan 29, 2026

View reviewed changes

sentry/src/main/java/io/sentry/SentryOptions.java Show resolved Hide resolved

cursor bot reviewed Jan 29, 2026

View reviewed changes

sentry-samples/sentry-samples-android/build.gradle.kts Show resolved Hide resolved

enabled -> enable

9d9efad

romtsn enabled auto-merge (squash) January 29, 2026 15:12

cursor bot reviewed Jan 29, 2026

View reviewed changes

sentry/src/main/java/io/sentry/SentryOptions.java Show resolved Hide resolved

romtsn merged commit 0eaac1e into main Jan 29, 2026
62 of 63 checks passed

romtsn deleted the rz/fix/spotlight-insecure-url branch January 29, 2026 15:34

sentry-release-bot bot mentioned this pull request Feb 9, 2026

publish: getsentry/sentry-java@8.32.0 getsentry/publish#7089

Closed

3 tasks

romtsn mentioned this pull request Feb 10, 2026

feat(java, android): Add Spotlight integration docs getsentry/sentry-docs#16323

Merged

6 tasks

Uh oh!

Conversation

romtsn commented Jan 28, 2026

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Semver Impact of This PR

New Features ✨

Bug Fixes 🐛

Internal Changes 🔧

Deps

Other

Uh oh!

github-actions bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: rz/fix/spotlight-insecure-url

Startup times

App size

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Jan 28, 2026 •

edited

Loading

github-actions bot commented Jan 28, 2026 •

edited

Loading

github-actions bot commented Jan 28, 2026 •

edited

Loading