Skip to content

fix(logs): Reject new logs if LoggerBatchProcessor is shutting down#5041

Merged
adinauer merged 3 commits intomainfrom
fix/reject-logs-on-shutdown
Jan 20, 2026
Merged

fix(logs): Reject new logs if LoggerBatchProcessor is shutting down#5041
adinauer merged 3 commits intomainfrom
fix/reject-logs-on-shutdown

Conversation

@adinauer
Copy link
Member

@adinauer adinauer commented Jan 20, 2026

📜 Description

Reject new logs if LoggerBatchProcessor is shutting down

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026 •
edited
Loading

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

New Features ✨

  • (logs) Replace sentry.trace.parent_span_id attribute with spanId property on SentryLogEvent by adinauer in #5040
  • Allow setting native SDK name in manifest by bitsandfoxes in #5027

Bug Fixes 🐛

Logs

  • Reject new logs if LoggerBatchProcessor is shutting down by adinauer in #5041
  • Check sendDefaultPii before attaching user attributes by adinauer in #5036

Build / dependencies / internal 🔧

Deps

  • Bump JamesIves/github-pages-deploy-action from 4.7.6 to 4.8.0 by dependabot in #5015
  • Update Native SDK to v0.12.3 by github-actions in #5012
  • Bump github/codeql-action from 4.31.8 to 4.31.10 by dependabot in #5032

Other

  • (release) Switch from action-prepare-release to Craft by BYK in #5014
  • (repo) Add Claude Code settings with basic permissions by philipphofmann in #5038

🤖 This preview updates automatically when you update the PR.

cursor[bot]
cursor bot reviewed Jan 20, 2026
View reviewed changes
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

sentry/src/main/java/io/sentry/logger/LoggerBatchProcessor.java
public void add(final @NotNull SentryLogEvent logEvent) {
if (isShuttingDown) {
return;
}
Copy link

@cursor cursor bot Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logs dropped during shutdown not recorded as lost events

Low Severity

When isShuttingDown is true, the add method silently returns without recording the dropped log event via recordLostEvent(). This is inconsistent with the queue overflow handling just below, which properly records both LogItem and LogByte lost events with DiscardReason.QUEUE_OVERFLOW. This inconsistency means logs discarded during shutdown won't appear in client reports, reducing observability into event loss.

Fix in Cursor Fix in Web

Copy link
Member

@markushi markushi Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO that's fine, at the point where the SDK is closed, it should also not send and discarded events.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 318.34 ms 356.40 ms 38.06 ms
Size 1.58 MiB 2.20 MiB 635.33 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d217708 375.27 ms 415.68 ms 40.41 ms
d15471f 310.66 ms 368.19 ms 57.53 ms
27d7cf8 309.43 ms 364.27 ms 54.85 ms
d15471f 361.89 ms 378.07 ms 16.18 ms
27d7cf8 314.17 ms 347.00 ms 32.83 ms
cf708bd 434.73 ms 502.96 ms 68.22 ms
27d7cf8 306.76 ms 366.66 ms 59.90 ms
fc5ccaf 322.49 ms 405.25 ms 82.76 ms
fcec2f2 311.35 ms 384.94 ms 73.59 ms
dba088c 333.98 ms 381.16 ms 47.18 ms

App size

Revision Plain With Sentry Diff
d217708 1.58 MiB 2.10 MiB 532.97 KiB
d15471f 1.58 MiB 2.13 MiB 559.54 KiB
27d7cf8 1.58 MiB 2.12 MiB 549.42 KiB
d15471f 1.58 MiB 2.13 MiB 559.54 KiB
27d7cf8 1.58 MiB 2.12 MiB 549.42 KiB
cf708bd 1.58 MiB 2.11 MiB 539.71 KiB
27d7cf8 1.58 MiB 2.12 MiB 549.42 KiB
fc5ccaf 1.58 MiB 2.13 MiB 557.54 KiB
fcec2f2 1.58 MiB 2.12 MiB 551.51 KiB
dba088c 1.58 MiB 2.13 MiB 558.99 KiB

Previous results on branch: fix/reject-logs-on-shutdown

Startup times

Revision Plain With Sentry Diff
525eebf 343.48 ms 411.81 ms 68.33 ms
0a38756 317.37 ms 431.42 ms 114.05 ms

App size

Revision Plain With Sentry Diff
525eebf 1.58 MiB 2.20 MiB 635.37 KiB
0a38756 1.58 MiB 2.20 MiB 635.37 KiB

@adinauer adinauer changed the title feat(logs): Reject new logs if LoggerBatchProcessor is shutting down fix(logs): Reject new logs if LoggerBatchProcessor is shutting down Jan 20, 2026
@adinauer adinauer enabled auto-merge (squash) January 20, 2026 14:56
@adinauer adinauer merged commit 1564554 into main Jan 20, 2026
63 checks passed
@adinauer adinauer deleted the fix/reject-logs-on-shutdown branch January 20, 2026 15:10
@sentry-release-bot sentry-release-bot bot mentioned this pull request Jan 21, 2026
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@markushi markushi markushi approved these changes

@romtsn romtsn Awaiting requested review from romtsn romtsn is a code owner

@lcian lcian Awaiting requested review from lcian lcian is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adinauer @markushi