feat(envelope-item): Support metric type#4956
Merged
romtsn merged 6 commits intogetsentry:mainfrom Dec 9, 2025
Merged
Conversation
Contributor
Author
|
failing test is due to me not having permission on this repo. |
lucas-zimerman
requested review from
adinauer,
lcian,
markushi and
romtsn
as code owners
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
markushi
approved these changes
Dec 9, 2025
antonis
approved these changes
Dec 9, 2025
Contributor
Author
working as expected 🗡️
|
Contributor
Author
|
just adding a note that I can't merge PRs here :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Metric support - this PR is needed for Capacitor/Dart/Flutter/React-Native right now but will be needed in general in the future when Java also implements Metric support
💡 Motivation and Context
See metric protocol: https://develop.sentry.dev/sdk/telemetry/metrics/
Needed for processing envelope items with type
trace_metric. Without this change, Hybrid SDKs will lose their metric data by replacing typetrace_metricby__unknown__.💚 How did you test it?
Unit test
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Close #4957