fix: handle unparseable mime-type#4939
Merged
adinauer merged 6 commits intogetsentry:mainfrom Dec 3, 2025
Merged
Conversation
adinauer
approved these changes
Dec 1, 2025
Member
adinauer
left a comment
There was a problem hiding this comment.
Thanks for the PR @diogoosorio, I've added the implementation for Spring 6 / Spring Boot 3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Caught this one in production in one of our apps
Which we could easily replicate by sending a request with a
Content-Type: invalid(which is indeed an invalid mime-type). The app returns a 500 error.💡 Motivation and Context
This shouldn't cause an exception on the filter, determining if the content-type of the body is an acceptable one should not be handled by the Sentry request filter.
💚 How did you test it?
Create a minimal app Spring Boot MVC app with a
sentry.max-request-body-sizeproperty defined. Includesentry-spring-boot-starter-jakartaand send a request:See that a 500 error is returned. Re-run with this change and see that the request now goes through the remainder of the filter pipeline.
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps