fix(anr): Always report stacktraces for ANRv1#4918
Merged
Conversation
markushi
requested review from
adinauer,
lcian,
romtsn and
stefanosiano
as code owners
Member
Author
|
@sentry review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
sentry-android-core/src/main/java/io/sentry/android/core/AnrIntegrationFactory.java
Outdated
Show resolved
Hide resolved
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
sentry-android-core/src/main/java/io/sentry/android/core/AnrIntegrationFactory.java
Outdated
Show resolved
Hide resolved
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 604a261 | 380.65 ms | 451.27 ms | 70.62 ms |
| a416a65 | 295.53 ms | 373.74 ms | 78.21 ms |
| 889ecea | 367.58 ms | 437.52 ms | 69.94 ms |
| a5ab36f | 320.47 ms | 389.77 ms | 69.30 ms |
| 27d7cf8 | 397.90 ms | 498.65 ms | 100.75 ms |
| ee747ae | 400.46 ms | 423.61 ms | 23.15 ms |
| d217708 | 375.27 ms | 415.68 ms | 40.41 ms |
| fcec2f2 | 357.47 ms | 447.32 ms | 89.85 ms |
| 23d6b12 | 354.10 ms | 408.38 ms | 54.28 ms |
| d5a29b6 | 298.62 ms | 391.78 ms | 93.16 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 604a261 | 1.58 MiB | 2.10 MiB | 533.42 KiB |
| a416a65 | 1.58 MiB | 2.12 MiB | 555.26 KiB |
| 889ecea | 1.58 MiB | 2.11 MiB | 539.75 KiB |
| a5ab36f | 1.58 MiB | 2.12 MiB | 555.26 KiB |
| 27d7cf8 | 1.58 MiB | 2.12 MiB | 549.42 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| d217708 | 1.58 MiB | 2.10 MiB | 532.97 KiB |
| fcec2f2 | 1.58 MiB | 2.12 MiB | 551.50 KiB |
| 23d6b12 | 1.58 MiB | 2.10 MiB | 532.31 KiB |
| d5a29b6 | 1.58 MiB | 2.12 MiB | 549.37 KiB |
Previous results on branch: refactor/decouple-sentry-thread-factory
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| bb4a325 | 312.60 ms | 365.22 ms | 52.62 ms |
| fa4b1c9 | 327.00 ms | 369.06 ms | 42.06 ms |
| 985e853 | 300.61 ms | 353.67 ms | 53.06 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| bb4a325 | 1.58 MiB | 2.13 MiB | 557.41 KiB |
| fa4b1c9 | 1.58 MiB | 2.13 MiB | 557.45 KiB |
| 985e853 | 1.58 MiB | 2.13 MiB | 557.40 KiB |
adinauer
approved these changes
Nov 20, 2025
Member
adinauer
left a comment
adinauer
left a comment
There was a problem hiding this comment.
LGTM, left a question about some tests
| @Test | ||
| fun `when getCurrentThreads is called, not empty result`() { | ||
| val sut = fixture.getSut() | ||
| val threads = sut.getCurrentThreads(null) |
Member
There was a problem hiding this comment.
l some tests here used to implicitly have attachStacktrace=true, now we're explicitly passing false. Does that matter?
Member
Author
There was a problem hiding this comment.
Yeah that should be fine, we have some tests for extra covering the attachStacktrace flag
markushi
changed the title
43jay
pushed a commit
that referenced
this pull request
Nov 26, 2025
* refactor(core): Decouple SentryThreadFactory from SentryOptions * docs: Add PR #4918 to CHANGELOG * refactor(core): Update API dump after thread factory changes * Address PR feedback * Update CHANGELOG.md * Update CHANGELOG * Update CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactored
SentryThreadFactoryto remove its dependency onSentryOptions. Instead of passing the entire options object, the relevant configuration (whether to attach stack traces) is now passed as a boolean parameter through the method calls, this allows us to attach ANR (v1) stacktraces, to events, regardless of the SentryOptions.Motivation
Fixes #4904
Testing