feat(flags): Implement LaunchDarkly Integrations#4917
Merged
Conversation
Member
Author
|
Android snippet used for testing in our Sample Android App: |
Member
Author
|
Server snippet used for testing on our Spring Boot 3 sample: |
Contributor
|
adinauer
commented
Nov 19, 2025
Member
Author
|
Not sure how we would test this e2e on our samples since a LaunchDarkly account is needed to successfully retrieve flag values. |
Member
Author
|
Maybe we could utilize https://demo.app.launchdarkly.com/projects/default/flags?env=production&selected-env=production but I assume since this is public we can't really rely on it producing any predictable results for testing. Also not sure if / how we can get SDK and mobile keys for it. |
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 604a261 | 380.65 ms | 451.27 ms | 70.62 ms |
| ee747ae | 382.73 ms | 435.41 ms | 52.68 ms |
| b77456b | 393.26 ms | 441.10 ms | 47.84 ms |
| 9fbb112 | 401.87 ms | 515.87 ms | 114.00 ms |
| 806307f | 357.85 ms | 424.64 ms | 66.79 ms |
| 27d7cf8 | 309.43 ms | 364.27 ms | 54.85 ms |
| 7314dbe | 437.83 ms | 505.64 ms | 67.81 ms |
| d217708 | 375.27 ms | 415.68 ms | 40.41 ms |
| 96449e8 | 361.30 ms | 423.39 ms | 62.09 ms |
| 1df7eb6 | 397.04 ms | 429.64 ms | 32.60 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 604a261 | 1.58 MiB | 2.10 MiB | 533.42 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| b77456b | 1.58 MiB | 2.12 MiB | 548.11 KiB |
| 9fbb112 | 1.58 MiB | 2.11 MiB | 539.18 KiB |
| 806307f | 1.58 MiB | 2.10 MiB | 533.42 KiB |
| 27d7cf8 | 1.58 MiB | 2.12 MiB | 549.42 KiB |
| 7314dbe | 1.58 MiB | 2.10 MiB | 533.45 KiB |
| d217708 | 1.58 MiB | 2.10 MiB | 532.97 KiB |
| 96449e8 | 1.58 MiB | 2.11 MiB | 539.35 KiB |
| 1df7eb6 | 1.58 MiB | 2.10 MiB | 532.97 KiB |
markushi
reviewed
Nov 20, 2025
| } | ||
|
|
||
| @Override | ||
| public Map<String, Object> afterEvaluation( |
Member
There was a problem hiding this comment.
Since this is a public method anyway, we could write a test which mimics the afterEvaluation call, and verifies a mocked scope .addFeatureFlag() call is being made. WDYT?
markushi
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Implement LaunchDarkly Integrations for Android (
sentry-launchdarkly-android) and JVM (sentry-launchdarkly-server)💡 Motivation and Context
Closes #4867
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps