feat(flags): Implement OpenFeature Integration#4910
Conversation
|
| private final IScopes scopes; | ||
|
|
||
| public SentryOpenFeatureHook() { | ||
| this(ScopesAdapter.getInstance()); |
There was a problem hiding this comment.
SentryIntegrationPackageStorage calls are missing
| implementation(projects.sentryGraphql22) | ||
| implementation(projects.sentryQuartz) | ||
| implementation(projects.sentryAsyncProfiler) | ||
| implementation(projects.sentryOpenfeature) |
There was a problem hiding this comment.
More samples + e2e tests
| "sentry-opentelemetry:sentry-opentelemetry-agentless-spring", | ||
| "sentry-quartz", | ||
| "sentry-okhttp", | ||
| "sentry-openfeature", |
There was a problem hiding this comment.
+ Readme and bug report template
|
Also tested LaunchDarkly via OpenFeature locally - it works! |
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ee747ae | 357.79 ms | 421.84 ms | 64.05 ms |
| ae7fed0 | 293.84 ms | 380.22 ms | 86.38 ms |
| 9fbb112 | 404.51 ms | 475.65 ms | 71.14 ms |
| 27d7cf8 | 397.90 ms | 498.65 ms | 100.75 ms |
| a416a65 | 333.78 ms | 410.37 ms | 76.59 ms |
| d217708 | 411.22 ms | 430.86 ms | 19.63 ms |
| 539ca63 | 313.51 ms | 355.43 ms | 41.92 ms |
| 23d6b12 | 354.10 ms | 408.38 ms | 54.28 ms |
| 14ff5ee | 419.75 ms | 495.73 ms | 75.98 ms |
| ce0a49e | 532.00 ms | 609.96 ms | 77.96 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| ae7fed0 | 1.58 MiB | 2.12 MiB | 551.77 KiB |
| 9fbb112 | 1.58 MiB | 2.11 MiB | 539.18 KiB |
| 27d7cf8 | 1.58 MiB | 2.12 MiB | 549.42 KiB |
| a416a65 | 1.58 MiB | 2.12 MiB | 555.26 KiB |
| d217708 | 1.58 MiB | 2.10 MiB | 532.97 KiB |
| 539ca63 | 1.58 MiB | 2.12 MiB | 551.41 KiB |
| 23d6b12 | 1.58 MiB | 2.10 MiB | 532.31 KiB |
| 14ff5ee | 1.58 MiB | 2.10 MiB | 535.08 KiB |
| ce0a49e | 1.58 MiB | 2.10 MiB | 532.94 KiB |
adinauer
requested review from
lcian,
markushi,
romtsn and
stefanosiano
as code owners
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
sentry-openfeature/src/main/java/io/sentry/openfeature/SentryOpenFeatureHook.java
Show resolved
Hide resolved
adinauer
changed the title
| maven:io.sentry:sentry-android-fragment: | ||
| maven:io.sentry:sentry-bom: | ||
| maven:io.sentry:sentry-openfeign: | ||
| #maven:io.sentry:sentry-openfeature: |
There was a problem hiding this comment.
Bug: OpenFeature module commented out in release registry
The sentry-openfeature entry is commented out in the craft registry configuration while the module is fully implemented and integrated. This will prevent the artifact from being published to Maven Central during releases, making it unavailable to users despite being documented and built.
| maven:io.sentry:sentry-android-fragment: | ||
| maven:io.sentry:sentry-bom: | ||
| maven:io.sentry:sentry-openfeign: | ||
| #maven:io.sentry:sentry-openfeature: |
There was a problem hiding this comment.
Bug: OpenFeature module commented out in release registry
The sentry-openfeature entry is commented out in the craft registry while the module is fully implemented and integrated. This will prevent the artifact from being published to Maven Central during releases, making it unavailable to users despite being documented and built.
3 participants
📜 Description
Implement a hook for OpenFeature that tracks feature flag evaluations.
💡 Motivation and Context
Closes #4905
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps