Skip to content

Handle NoOpScopes in Context when starting a span through OpenTelemetry#4823

Merged
adinauer merged 4 commits intomainfrom
fix/handle-noop-scopes-in-span-processor
Oct 22, 2025
Merged

Handle NoOpScopes in Context when starting a span through OpenTelemetry#4823
adinauer merged 4 commits intomainfrom
fix/handle-noop-scopes-in-span-processor

Conversation

@adinauer
Copy link
Member

@adinauer adinauer commented Oct 21, 2025 •
edited
Loading

📜 Description

Treat NoOpScopes the same as null in OtelSentrySpanProcessor and fork root scopes.

💡 Motivation and Context

Fixes #4806

It was causing customers requests to fail due to SentryReactorThreadLocalAccessor storing NoOpScopes into OpenTelemetry Context and OtelSentrySpanProcessor then trying to fork that instead of forking root scopes.

💚 How did you test it?

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@adinauer adinauer mentioned this pull request Oct 21, 2025
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2025 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 318.08 ms 373.64 ms 55.56 ms
Size 1.58 MiB 2.12 MiB 549.37 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d364ace 411.72 ms 430.81 ms 19.10 ms
ee747ae 396.82 ms 441.67 ms 44.86 ms
ee747ae 415.92 ms 470.15 ms 54.23 ms
889ecea 367.58 ms 437.52 ms 69.94 ms
b77456b 393.26 ms 441.10 ms 47.84 ms
f634d01 375.06 ms 420.04 ms 44.98 ms
b750b96 408.98 ms 480.32 ms 71.34 ms
b3d8889 371.69 ms 432.96 ms 61.26 ms
9fbb112 401.87 ms 515.87 ms 114.00 ms
ee747ae 358.21 ms 389.41 ms 31.20 ms

App size

Revision Plain With Sentry Diff
d364ace 1.58 MiB 2.11 MiB 539.75 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
889ecea 1.58 MiB 2.11 MiB 539.75 KiB
b77456b 1.58 MiB 2.12 MiB 548.11 KiB
f634d01 1.58 MiB 2.10 MiB 533.40 KiB
b750b96 1.58 MiB 2.10 MiB 533.19 KiB
b3d8889 1.58 MiB 2.10 MiB 535.06 KiB
9fbb112 1.58 MiB 2.11 MiB 539.18 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB

Previous results on branch: fix/handle-noop-scopes-in-span-processor

Startup times

Revision Plain With Sentry Diff
c588533 331.68 ms 408.20 ms 76.52 ms

App size

Revision Plain With Sentry Diff
c588533 1.58 MiB 2.12 MiB 549.37 KiB

@adinauer adinauer merged commit 7a04ad6 into main Oct 22, 2025
61 checks passed
@adinauer adinauer deleted the fix/handle-noop-scopes-in-span-processor branch October 22, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcian lcian lcian approved these changes

@romtsn romtsn Awaiting requested review from romtsn romtsn is a code owner

@stefanosiano stefanosiano Awaiting requested review from stefanosiano

@markushi markushi Awaiting requested review from markushi markushi is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

runBlocking coroutines with sentry-opentelemetry-agentless-spring throws error on e.g. webclient calls

2 participants

@adinauer @lcian