Conversation
…ndler to invoke their callbacks on
romtsn
requested review from
adinauer,
lcian,
markushi and
stefanosiano
as code owners
Member
Author
Contributor
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 23d6b12 | 354.10 ms | 408.38 ms | 54.28 ms |
| 9fbb112 | 361.43 ms | 427.57 ms | 66.14 ms |
| 1df7eb6 | 397.04 ms | 429.64 ms | 32.60 ms |
| c8125f3 | 397.65 ms | 485.14 ms | 87.49 ms |
| ee747ae | 358.21 ms | 389.41 ms | 31.20 ms |
| b750b96 | 408.98 ms | 480.32 ms | 71.34 ms |
| f634d01 | 359.58 ms | 433.88 ms | 74.30 ms |
| 806307f | 357.85 ms | 424.64 ms | 66.79 ms |
| ee747ae | 374.71 ms | 455.18 ms | 80.47 ms |
| ce0a49e | 532.00 ms | 609.96 ms | 77.96 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 23d6b12 | 1.58 MiB | 2.10 MiB | 532.31 KiB |
| 9fbb112 | 1.58 MiB | 2.11 MiB | 539.18 KiB |
| 1df7eb6 | 1.58 MiB | 2.10 MiB | 532.97 KiB |
| c8125f3 | 1.58 MiB | 2.10 MiB | 532.32 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| b750b96 | 1.58 MiB | 2.10 MiB | 533.19 KiB |
| f634d01 | 1.58 MiB | 2.10 MiB | 533.40 KiB |
| 806307f | 1.58 MiB | 2.10 MiB | 533.42 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| ce0a49e | 1.58 MiB | 2.10 MiB | 532.94 KiB |
|
Hi @romtsn, this is amazing - thanks so much! I can confirm that both network and battery breadcrumbs are delivered in the main thread with this. 👍 |
Member
Author
|
@jpnurmi great, thanks for trying out! I will wait for the maintainers' review and then merge and ship it soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
Part of getsentry/sentry-dotnet#3828
Closes #4700
💚 How did you test it?
Automated
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps