Only send session update for dropped events if state changed#2002
Merged
Only send session update for dropped events if state changed#2002
Conversation
4 tasks
adinauer
commented
Apr 22, 2022
Codecov Report
@@ Coverage Diff @@
## fix/event-drop-session-update-inconsistencies #2002 +/- ##
===================================================================================
+ Coverage 80.77% 80.79% +0.01%
- Complexity 3131 3146 +15
===================================================================================
Files 228 228
Lines 11622 11642 +20
Branches 1556 1565 +9
===================================================================================
+ Hits 9388 9406 +18
- Misses 1648 1649 +1
- Partials 586 587 +1
Continue to review full report at Codecov.
|
marandaneto
reviewed
Apr 25, 2022
…/event-drop-session-update-inconsistencies-extra
…/event-drop-session-update-inconsistencies-extra
adinauer
changed the title
adinauer
commented
Apr 26, 2022
…/event-drop-session-update-inconsistencies-extra
marandaneto
reviewed
Apr 26, 2022
marandaneto
reviewed
Apr 26, 2022
Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
… github.com:getsentry/sentry-java into fix/event-drop-session-update-inconsistencies-extra
…/event-drop-session-update-inconsistencies-extra
adinauer
changed the title
romtsn
approved these changes
May 3, 2022
... where the session update is not sent because it does not change the health of the sesssion
Base automatically changed from
fix/event-drop-session-update-inconsistencies
to
6.x.x
May 3, 2022 08:49
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Extra for #2001 to only send session update for dropped events if session state changed (healty -> errored or errored -> crashed).
💡 Motivation and Context
See linked PR for more context. This should ensure session updates make it to the server for dropped events that changed the session state.
💚 How did you test it?
📝 Checklist
🔮 Next steps