Skip to content

Vendor JSON: Remove IUnknownPropertiesConsumer#1749

Merged
denrase merged 2 commits into
feat/vendor-json-writer-readerfrom
feat/vendor-json-remove-unknown-properties-consumer
Oct 8, 2021
Merged

Vendor JSON: Remove IUnknownPropertiesConsumer#1749
denrase merged 2 commits into
feat/vendor-json-writer-readerfrom
feat/vendor-json-remove-unknown-properties-consumer

Conversation

@denrase

@denrase denrase commented Oct 4, 2021

Copy link
Copy Markdown
Collaborator

#skip-changelog

📜 Description

  • Removes IUnknownPropertiesConsumer

💡 Motivation and Context

💚 How did you test it?

  • No testing needed, as we only removal took place.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

@denrase denrase marked this pull request as ready for review October 4, 2021 09:20
@denrase denrase changed the title Vendor Json: Remove IUnknownPropertiesConsumer Vendor JSON: Remove IUnknownPropertiesConsumer Oct 4, 2021
@denrase denrase mentioned this pull request Oct 4, 2021
47 tasks
Comment thread sentry/src/test/java/io/sentry/GsonSerializerTest.kt Outdated
@marandaneto

Copy link
Copy Markdown
Contributor

I believe we should delete the UnknownPropertiesTypeAdapterFactory class as well

@denrase

denrase commented Oct 5, 2021

Copy link
Copy Markdown
Collaborator Author

UnknownPropertiesTypeAdapterFactory is deleted in this PR, or did i miss something?

@marandaneto

Copy link
Copy Markdown
Contributor

UnknownPropertiesTypeAdapterFactory is deleted in this PR, or did i miss something?

indeed, missed it somehow in the git diff

…emove-unknown-properties-consumer

# Conflicts:
#	sentry/api/sentry.api
#	sentry/src/main/java/io/sentry/GsonSerializer.java
@denrase denrase merged commit 4bcb126 into feat/vendor-json-writer-reader Oct 8, 2021
@denrase denrase deleted the feat/vendor-json-remove-unknown-properties-consumer branch October 8, 2021 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants