Skip to content

Vendor JSON: Json Serializer#1744

Merged
denrase merged 19 commits into
feat/vendor-json-writer-readerfrom
feat/vendor-json-vendor-serializer
Oct 8, 2021
Merged

Vendor JSON: Json Serializer#1744
denrase merged 19 commits into
feat/vendor-json-writer-readerfrom
feat/vendor-json-vendor-serializer

Conversation

@denrase

@denrase denrase commented Sep 28, 2021

Copy link
Copy Markdown
Collaborator

#skip-changelog

📜 Description

This PR adds the JsonSerializer which implements the ISerializer interface and acts as the drop in replacement for the GsonSerializer.

💡 Motivation and Context

This sets our new serialization approach as the default but also leaves the option to users to opt out of it.

  • The new serializer is set as the default one in SentryOptions
  • Fixes remaining known issues with parsing null values for set keys in payloads.
  • Clients using this should be aware that there is currently no reflection support.
  • Removes gson dependency.

💚 How did you test it?

  • Use the new JsonSerializer in the GsonSerializer tests and rename them to JsonSerializer tests.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@denrase denrase self-assigned this Sep 28, 2021
@denrase denrase marked this pull request as ready for review September 30, 2021 13:14
@denrase denrase mentioned this pull request Oct 4, 2021
47 tasks
@marandaneto

Copy link
Copy Markdown
Contributor

GsonSerializer is still present so users can opt-out during the testing phase.

if the idea is dropping the Gson dependency, not sure if this is a good approach.
ideally, we'd do a major bump and have a few weeks of alpha/beta/rc cycle so we are sure we're not breaking anything, but already gaining a few KBs due to removing gson.

@denrase

denrase commented Oct 5, 2021

Copy link
Copy Markdown
Collaborator Author

@marandaneto Sounds good to me, will put the PR back to draft and remove GSON.

@denrase denrase marked this pull request as draft October 5, 2021 09:44
@denrase denrase marked this pull request as ready for review October 5, 2021 13:41
@denrase denrase merged commit 923d79f into feat/vendor-json-writer-reader Oct 8, 2021
@denrase denrase deleted the feat/vendor-json-vendor-serializer branch October 8, 2021 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants