Vendor JSON: Json Serializer#1744
Merged
denrase merged 19 commits intoOct 8, 2021
Merged
Conversation
Contributor
if the idea is dropping the Gson dependency, not sure if this is a good approach. |
Collaborator
Author
|
@marandaneto Sounds good to me, will put the PR back to draft and remove GSON. |
4 tasks
…ect (non-null property forece set to null)
… parsing in attr object
marandaneto
approved these changes
Oct 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#skip-changelog
📜 Description
This PR adds the
JsonSerializerwhich implements theISerializerinterface and acts as the drop in replacement for theGsonSerializer.💡 Motivation and Context
This sets our new serialization approach as the default but also leaves the option to users to opt out of it.
SentryOptionsgsondependency.💚 How did you test it?
JsonSerializerin theGsonSerializertests and rename them toJsonSerializertests.📝 Checklist
🔮 Next steps