Skip to content

Vendor JSON: TraceState#1736

Merged
denrase merged 2 commits into
feat/vendor-json-writer-readerfrom
feat/vendor-json-trace-state
Sep 23, 2021
Merged

Vendor JSON: TraceState#1736
denrase merged 2 commits into
feat/vendor-json-writer-readerfrom
feat/vendor-json-trace-state

Conversation

@denrase

@denrase denrase commented Sep 23, 2021

Copy link
Copy Markdown
Collaborator

#skip-changelog

📜 Description

  • Implement serialization/deserialization for TraceState, TraceState
  • Update serialization/deserialization for SentryEnvelopeHeader

💚 How did you test it?

  • Added tests.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@denrase denrase self-assigned this Sep 23, 2021
@denrase denrase changed the base branch from main to feat/vendor-json-writer-reader September 23, 2021 09:12
@denrase denrase changed the title Feat/vendor json trace state Vendor JSON: TraceState Sep 23, 2021
@denrase denrase marked this pull request as ready for review September 23, 2021 09:24
@denrase denrase mentioned this pull request Sep 23, 2021
47 tasks
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #1736 (05c69fd) into feat/vendor-json-writer-reader (c4af87e) will decrease coverage by 0.16%.
The diff coverage is 63.20%.

❗ Current head 05c69fd differs from pull request most recent head 356f5fa. Consider uploading reports for the commit 356f5fa to get more accurate results
Impacted file tree graph

@@                         Coverage Diff                          @@
##             feat/vendor-json-writer-reader    #1736      +/-   ##
====================================================================
- Coverage                             79.40%   79.24%   -0.17%     
- Complexity                             2814     2816       +2     
====================================================================
  Files                                   221      221              
  Lines                                 10533    10638     +105     
  Branches                               1398     1417      +19     
====================================================================
+ Hits                                   8364     8430      +66     
- Misses                                 1608     1634      +26     
- Partials                                561      574      +13     
Impacted Files Coverage Δ
sentry/src/main/java/io/sentry/TraceState.java 69.06% <62.00%> (-18.12%) ⬇️
.../src/main/java/io/sentry/SentryEnvelopeHeader.java 91.07% <83.33%> (-1.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4af87e...356f5fa. Read the comment docs.

@denrase denrase merged commit ac2f814 into feat/vendor-json-writer-reader Sep 23, 2021
@denrase denrase deleted the feat/vendor-json-trace-state branch September 23, 2021 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants