Skip to content

Vendor Json: SentryEnvelope#1722

Merged
denrase merged 2 commits into
feat/vendor-json-sentry-transactionfrom
feat/vendor-json-sentry-envelope
Sep 21, 2021
Merged

Vendor Json: SentryEnvelope#1722
denrase merged 2 commits into
feat/vendor-json-sentry-transactionfrom
feat/vendor-json-sentry-envelope

Conversation

@denrase

@denrase denrase commented Sep 15, 2021

Copy link
Copy Markdown
Collaborator

#skip-changelog

📜 Description

  • Implement serialization/deserialization for SentryEnvelopeHeader
  • Implement serialization/deserialization for SentryEnvelopeItemHeader

💚 How did you test it?

  • Added tests.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@denrase denrase self-assigned this Sep 15, 2021
@marandaneto

Copy link
Copy Markdown
Contributor

@bruno-garcia wondering if we need to implement the JsonUnknown strategy here too (since it's the envelope bits), wdyt?

@denrase

denrase commented Sep 15, 2021

Copy link
Copy Markdown
Collaborator Author

Figured it's very unlikely that the envelope and envelope item headers will change, but that's probably true for many other models as well. We can add them as well.

@denrase denrase marked this pull request as ready for review September 15, 2021 15:16
@denrase denrase mentioned this pull request Sep 15, 2021
47 tasks
@marandaneto

Copy link
Copy Markdown
Contributor

Figured it's very unlikely that the envelope and envelope item headers will change, but that's probably true for many other models as well. We can add them as well.

yeah lets add it then

@denrase

denrase commented Sep 21, 2021

Copy link
Copy Markdown
Collaborator Author

@marandaneto done

@denrase denrase merged commit 6c2f744 into feat/vendor-json-sentry-transaction Sep 21, 2021
@denrase denrase deleted the feat/vendor-json-sentry-envelope branch September 21, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants