Vendor Json: SentryEvent#1716
Merged
denrase merged 4 commits intoSep 21, 2021
Merged
Conversation
denrase
requested review from
bruno-garcia,
maciejwalkowiak and
marandaneto
as code owners
Contributor
|
@denrase looks like I already reviewed part of this PR, is the target branch wrong? or should we merge the approved branches to make it easier? |
Collaborator
Author
|
@marandaneto Should be correct? |
marandaneto
approved these changes
Sep 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#skip-changelog
📜 Description
SentryBaseEventtimestampofSentryEventis not final anymore, so it can be assigned during deserialization, where we need to have an instance while iterating keys and assigning base event properties.Message💚 How did you test it?
📝 Checklist
🔮 Next steps