Skip to content

Vendor JSON: DebugMeta#1685

Merged
denrase merged 5 commits into
feat/vendor-json-writer-readerfrom
feat/vendor-json-debug-meta
Aug 30, 2021
Merged

Vendor JSON: DebugMeta#1685
denrase merged 5 commits into
feat/vendor-json-writer-readerfrom
feat/vendor-json-debug-meta

Conversation

@denrase

@denrase denrase commented Aug 30, 2021

Copy link
Copy Markdown
Collaborator

#skip-changelog

📜 Description

  • Implement serialization/deserialization for SdkInfo
  • Implement serialization/deserialization for DebugImage
  • Implement serialization/deserialization for DebugMeta
  • Added nextList to JsonObjectReader

💚 How did you test it?

  • Added tests.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@denrase denrase self-assigned this Aug 30, 2021
@denrase denrase marked this pull request as ready for review August 30, 2021 09:59
list.add(deserializer.deserialize(this, logger));
} catch (Exception e) {
logger.log(SentryLevel.ERROR, "Failed to deserialize object in list.", e);
e.printStackTrace();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove that

Comment thread sentry/src/test/java/io/sentry/protocol/DebugMetaSerializationTest.kt Outdated
@denrase denrase mentioned this pull request Aug 30, 2021
47 tasks
@denrase denrase merged commit 35923ff into feat/vendor-json-writer-reader Aug 30, 2021
@denrase denrase deleted the feat/vendor-json-debug-meta branch August 30, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants