Type-safe project accessors in Gradle config.#1644
Merged
Conversation
maciejwalkowiak
requested review from
bruno-garcia and
marandaneto
as code owners
Contributor
it does when you rename a project, but that's the only difference I guess |
marandaneto
approved these changes
Aug 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Type-safe project accessors in Gradle config.
💡 Motivation and Context
Fixes #1452.
Since this is an incubating feature, I am not convinced we should use it. I does not seem to hurt but also does not seem to bring much value.
📝 Checklist
#skip-changelog