Feat: Slow/Frozen frames metrics#1609
Merged
Merged
Conversation
marandaneto
commented
Jul 20, 2021
Codecov Report
@@ Coverage Diff @@
## main #1609 +/- ##
============================================
- Coverage 75.93% 75.93% -0.01%
- Complexity 2003 2004 +1
============================================
Files 202 202
Lines 6939 6943 +4
Branches 690 691 +1
============================================
+ Hits 5269 5272 +3
- Misses 1334 1335 +1
Partials 336 336
Continue to review full report at Codecov.
|
philipphofmann
left a comment
philipphofmann
left a comment
Member
There was a problem hiding this comment.
Looks already good. I added a few comments.
philipphofmann
left a comment
philipphofmann
left a comment
Member
There was a problem hiding this comment.
Just one open comment about the naming. Is it hard to add tests for ActivityFramesTracker or how is it tested?
bruno-garcia
left a comment
bruno-garcia
left a comment
Member
There was a problem hiding this comment.
Just a couple notes (given it's a draft)
philipphofmann
left a comment
philipphofmann
left a comment
Member
There was a problem hiding this comment.
One tiny comment, and is it possible to add tests for ActivityFramesTracker?
4 tasks
jennmueng
reviewed
Jul 27, 2021
bruno-garcia
approved these changes
Jul 27, 2021
bruno-garcia
left a comment
bruno-garcia
left a comment
Member
There was a problem hiding this comment.
Other than some small suggestions LGTM! 🚀
Contributor
Author
applied them and added one more test too, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Feat: Slow/Frozen frames metrics
💡 Motivation and Context
Closes #1466
💚 How did you test it?
📝 Checklist
🔮 Next steps