Normalize DSN URI.#1032
Merged
Merged
Conversation
maciejwalkowiak
requested review from
bruno-garcia and
marandaneto
as code owners
5 tasks
marandaneto
approved these changes
Nov 5, 2020
marandaneto
left a comment
marandaneto
left a comment
Contributor
There was a problem hiding this comment.
LGTM but this also could be an issue on the sentry server, right? the URL should be normalized there also before shown on the UI
Contributor
Author
|
Yes I believe it should be fixed on the UI side too. |
Codecov Report
@@ Coverage Diff @@
## main #1032 +/- ##
=========================================
Coverage 71.98% 71.98%
Complexity 1321 1321
=========================================
Files 135 135
Lines 4816 4816
Branches 492 492
=========================================
Hits 3467 3467
Misses 1091 1091
Partials 258 258
Continue to review full report at Codecov.
|
bruno-garcia
approved these changes
Nov 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Normalizes DSN URI.
💡 Motivation and Context
#1030
💚 How did you test it?
Unit tests.
📝 Checklist