Repository navigation
[DRAFT] chore(mypy): remove query_builder from typing issues list - #128743
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Armen Zambrano G. <armenzg@users.noreply.github.com>
github-actions
Bot
added
the
Scope: Backend
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sentry.snuba.metrics.query_builderfrom the mypysentry modules with typing issuesoverride list.sentry.snuba.metrics.query_builderto thenot yet strongly typedweaklist.query_buildersurfaced by removing the override (type narrowing around group/order fields, optional interval handling, stricter RHS tag-resolution typing, and stronger tuple type annotations).MetricOperationParamsinsrc/sentry/snuba/metrics/fields/base.pyto match the shapes already carried byMetricField.params.Testing
.venv/bin/python -m mypy --config-file pyproject.toml src/sentry/snuba/metrics/query_builder.py.venv/bin/python -m mypy --config-file pyproject.toml src/sentry/snuba/metrics/fields/base.py.venv/bin/python -uSm tools.mypy_helpers.check_stronglist pyproject.toml.venv/bin/prek run -qSENTRY_SKIP_SERVICE_VALIDATION=1 .venv/bin/pytest -n0 -svv --reuse-db tests/sentry/test_mypy_stronglist.py(test body passed, teardown failed in this VM due missing local Redis/Docker services)Reviewer
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.