Repository navigation
Conversation
github-actions
Bot
added
the
Scope: Backend
nora-shap
force-pushed
the
nora/auth/ID-1864
branch
from
October 23, 2026 23:00
6a00886 to
e829521
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two email comparisons still used Python's Unicode-aware lowercasing. Unicode case mapping can turn some non-ASCII characters into ASCII ones (for example, U+212A lowercases to "k"), so a look-alike address could be treated as an existing one.
AuthIdentityHandler._email_verified_via_pending_invitecompared the SSO identity email to the invited email with.lower(). It now usesemails_match, the ASCII-only helper from ref(auth): Apply consistent email matching in user service and SSO verification #127401.RegistrationValidator.validate_emailreturnedvalue.lower(), so a look-alike address was saved as the ASCII address it resembles. It now returnsascii_casefold(value), which lowercases only A-Z.The duplicate-account check in
validate_emailintentionally keepsiexact. PostgresUPPERmatches some look-alikes (for example, "ı" to "I"), and for a uniqueness check, over-matching is the safe direction: it refuses to create a look-alike twin of an existing account.