fix: inline registration schema definitions#423
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5c5a61d. Configure here.
| .$defs as JsonObject) ?? {}), | ||
| }, | ||
| }); | ||
| expect((jsonSchema.oneOf as JsonObject[])[0].$defs).toBeUndefined(); |
There was a problem hiding this comment.
Smoke test asserts opposite of new behavior
High Severity
The smoke test in e2e-mcp-discovery.test.ts asserts listSimsOutputSchema?.oneOf?.[0]?.$defs is defined, but the production code change in getMcpOutputSchemaForRegistrationJson now strips $defs from oneOf entries via inlineRegistrationSchemaResource. The unit test explicitly asserts the opposite: oneOf[0].$defs is undefined. This smoke test will fail at runtime because it was not updated to match the new inlining behavior.
Additional Locations (1)
Triggered by project rule: Bugbot Review Guide for XcodeBuildMCP
Reviewed by Cursor Bugbot for commit 5c5a61d. Configure here.
1 participant
Summary
Closes #419
Testing