Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: getpatchwork/patchwork
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: getpatchwork/patchwork
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: stable/3.2
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 9 commits
  • 8 files changed
  • 3 contributors

Commits on Oct 31, 2024

  1. docker: Update tag

    This will need to be part of our release procedure going forward.
    
    Signed-off-by: Stephen Finucane <stephen@that.guru>
    stephenfin committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    0da3021 View commit details
    Browse the repository at this point in the history
  2. templates/submission: Fix alignment of commit message

    Preformatted content must not be indented
    because any space is kept in the output,
    making the content wrongly indented.
    
    When aligning message headers to the left,
    the new HTML code has been indented
    including some preformatted content indented with two spaces.
    
    The fix is to remove the indent of the content.
    
    Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
    Fixes: fe34ab2 ("patch-detail: left align message headers")
    Reviewed-by: Robin Jarry <robin@jarry.cc>
    Reviewed-by: Stephen Finucane <stephen@that.guru>
    (cherry picked from commit 13bbc0d)
    tmonjalo authored and stephenfin committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    b35f6e3 View commit details
    Browse the repository at this point in the history
  3. Release 3.2.1

    Signed-off-by: Stephen Finucane <stephen@that.guru>
    stephenfin committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    1455a92 View commit details
    Browse the repository at this point in the history
  4. Post-release version bump

    Signed-off-by: Stephen Finucane <stephen@that.guru>
    stephenfin committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    b2374a0 View commit details
    Browse the repository at this point in the history
  5. Fix version.txt

    Fixes: b2374a0 ("Post-release version bump")
    Signed-off-by: Stephen Finucane <stephen@that.guru>
    stephenfin committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    3e92448 View commit details
    Browse the repository at this point in the history
  6. CI: Cancel builds upon a new push

    Signed-off-by: Stephen Finucane <stephen@that.guru>
    (cherry picked from commit 09939ba)
    stephenfin committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    95682fd View commit details
    Browse the repository at this point in the history
  7. tests: Dump more info if version test fails

    Signed-off-by: Stephen Finucane <stephen@that.guru>
    (cherry picked from commit fa14cf8)
    stephenfin committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    5c4b660 View commit details
    Browse the repository at this point in the history
  8. css: make diff colors more accessible

    The colors used to display patch diffs are confusing. The context color
    is very similar to the added line color and the contrast between added
    and removed lines is very low.
    
    Originally, the choice of purple/blue (instead of the more common
    red/green palette) may have been made with colorblindness accessibility
    in mind. However, after inspecting the current colors with
    colorblindness "simulators", I found that the low contrast was
    consistent no matter what vision deficiency (if any) you might have.
    
    Update the colors to use a more common red/green palette. Add background
    colors to increase contrast for colorblind people. Use less confusing
    colors for context and diff hunks. Use normal line height to prevent
    background colors from overlapping. Use a different color for email
    quotes (blue) to avoid confusion with added lines.
    
    I have made a compilation of the current and updated color palette
    previews for normal vision and all common color deficiencies. I also
    included the same diff as seen from Github interface for reference.
    
    Link: http://files.diabeteman.com/patchwork-diff-colors/
    Signed-off-by: Robin Jarry <robin@jarry.cc>
    (cherry picked from commit c443cd9)
    rjarry authored and stephenfin committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    794bdb9 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. views: Switch logout to POST

    This was deprecated in 4.1 and removed in 5.0. I missed it.
    
    [1] https://docs.djangoproject.com/en/5.0/releases/4.1/#features-deprecated-in-4-1
    
    Signed-off-by: Stephen Finucane <stephen@that.guru>
    (cherry picked from commit 45f47e9)
    stephenfin committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    5b5fef5 View commit details
    Browse the repository at this point in the history
Loading