Repository navigation
Expand file tree
/
Copy pathtest_parser.py
More file actions
1572 lines (1261 loc) · 53.7 KB
/
Copy pathtest_parser.py
File metadata and controls
1572 lines (1261 loc) · 53.7 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
# Patchwork - automated patch tracking system
# Copyright (C) 2008 Jeremy Kerr <jk@ozlabs.org>
#
# SPDX-License-Identifier: GPL-2.0-or-later
import email
from email import message_from_string
from email.mime.multipart import MIMEMultipart
from email.mime.text import MIMEText
from email.utils import make_msgid
import os
from django.test import TestCase
from django.test import TransactionTestCase
from django.db.transaction import atomic
from django.db import connection
from patchwork.models import Cover
from patchwork.models import CoverComment
from patchwork.models import Patch
from patchwork.models import PatchComment
from patchwork.models import Person
from patchwork.models import State
from patchwork import parser
from patchwork.parser import clean_subject
from patchwork.parser import get_or_create_author
from patchwork.parser import find_patch_content as find_content
from patchwork.parser import find_comment_content
from patchwork.parser import find_project
from patchwork.parser import find_series
from patchwork.parser import parse_mail as _parse_mail
from patchwork.parser import parse_pull_request
from patchwork.parser import parse_series_marker
from patchwork.parser import parse_version
from patchwork.parser import split_prefixes
from patchwork.parser import subject_check
from patchwork.parser import DuplicateMailError
from patchwork.tests import TEST_MAIL_DIR
from patchwork.tests import TEST_FUZZ_DIR
from patchwork.tests.utils import create_cover
from patchwork.tests.utils import create_cover_comment
from patchwork.tests.utils import create_patch
from patchwork.tests.utils import create_patch_comment
from patchwork.tests.utils import create_project
from patchwork.tests.utils import create_series
from patchwork.tests.utils import create_series_reference
from patchwork.tests.utils import create_state
from patchwork.tests.utils import create_user
from patchwork.tests.utils import read_patch
from patchwork.tests.utils import SAMPLE_DIFF
def load_mail(file_path):
with open(file_path, 'rb') as f:
mail = email.message_from_binary_file(f)
return mail
def read_mail(filename, project=None):
"""Read a mail from a file."""
file_path = os.path.join(TEST_MAIL_DIR, filename)
mail = load_mail(file_path)
if 'Message-Id' not in mail:
mail['Message-Id'] = make_msgid()
if project:
mail['List-Id'] = project.listid
return mail
def _create_email(
msg,
msgid=None,
subject=None,
sender=None,
listid=None,
in_reply_to=None,
references=None,
headers=None,
):
msg['Message-Id'] = msgid or make_msgid()
msg['Subject'] = subject or 'Test subject'
msg['From'] = sender or 'Test Author <test-author@example.com>'
msg['List-Id'] = listid or 'test.example.com'
if in_reply_to:
msg['In-Reply-To'] = in_reply_to
if references:
msg['References'] = references
for header in headers or {}:
msg[header] = headers[header]
return msg
def create_email(
content,
msgid=None,
subject=None,
sender=None,
listid=None,
in_reply_to=None,
references=None,
headers=None,
):
msg = MIMEText(content, _charset='us-ascii')
return _create_email(
msg,
msgid,
subject,
sender,
listid,
in_reply_to,
references,
headers,
)
def parse_mail(*args, **kwargs):
create_state()
return _parse_mail(*args, **kwargs)
class PatchTest(TestCase):
def _find_content(self, mbox_filename):
mail = read_mail(mbox_filename)
diff, message = find_content(mail)
return diff, message
class InlinePatchTest(PatchTest):
orig_content = 'Test for attached patch'
orig_diff = read_patch('0001-add-line.patch')
def setUp(self):
email = create_email(self.orig_content + '\n' + self.orig_diff)
self.diff, self.content = find_content(email)
def test_patch_content(self):
self.assertEqual(self.diff, self.orig_diff)
def test_patch_diff(self):
self.assertEqual(self.content, self.orig_content)
class AttachmentPatchTest(InlinePatchTest):
orig_content = 'Test for attached patch'
content_subtype = 'x-patch'
def setUp(self):
msg = MIMEMultipart()
body = MIMEText(self.orig_content, _subtype='plain')
attachment = MIMEText(self.orig_diff, _subtype=self.content_subtype)
msg.attach(body)
msg.attach(attachment)
email = _create_email(msg)
self.diff, self.content = find_content(email)
class AttachmentXDiffPatchTest(AttachmentPatchTest):
content_subtype = 'x-diff'
class UTF8InlinePatchTest(InlinePatchTest):
orig_diff = read_patch('0002-utf-8.patch', 'utf-8')
def setUp(self):
msg = MIMEText(
self.orig_content + '\n' + self.orig_diff, _charset='utf-8'
)
email = _create_email(msg)
self.diff, self.content = find_content(email)
class NoCharsetInlinePatchTest(InlinePatchTest):
"""Test mails with no content-type or content-encoding header."""
def setUp(self):
email = create_email(self.orig_content + '\n' + self.orig_diff)
del email['Content-Type']
del email['Content-Transfer-Encoding']
self.diff, self.content = find_content(email)
class SignatureCommentTest(InlinePatchTest):
orig_content = 'Test comment\nmore comment'
def setUp(self):
email = create_email(
self.orig_content + '\n-- \nsig\n' + self.orig_diff
)
self.diff, self.content = find_content(email)
class UpdateSigCommentTest(SignatureCommentTest):
"""Test for '---\nUpdate: v2' style comments to patches, with a sig."""
patch_filename = '0001-add-line.patch'
orig_content = 'Test comment\nmore comment\n---\nUpdate: test update'
class ListFooterTest(InlinePatchTest):
orig_content = 'Test comment\nmore comment'
def setUp(self):
email = create_email(
'\n'.join(
[
self.orig_content,
'_______________________________________________',
'Linuxppc-dev mailing list',
self.orig_diff,
]
)
)
self.diff, self.content = find_content(email)
class DiffWordInCommentTest(InlinePatchTest):
orig_content = (
'Lines can start with words beginning in "diff"\n'
+ 'difficult\nDifferent'
)
class UpdateCommentTest(InlinePatchTest):
"""Test for '---\nUpdate: v2' style comments to patches."""
orig_content = 'Test comment\nmore comment\n---\nUpdate: test update'
class SenderEncodingTest(TestCase):
"""Validate correct handling of encoded recipients."""
@staticmethod
def _create_email(from_header):
mail = (
'Message-Id: %s\n' % make_msgid()
+ 'From: %s\n' % from_header
+ 'Subject: test\n\n'
+ 'test'
)
return message_from_string(mail)
def _test_encoding(self, from_header, sender_name, sender_email):
email = self._create_email(from_header)
person = get_or_create_author(email)
person.save()
# ensure it was parsed correctly
self.assertEqual(person.name, sender_name)
self.assertEqual(person.email, sender_email)
# ...and that it's queryable from DB
db_person = Person.objects.get(name=sender_name)
self.assertEqual(person, db_person)
db_person = Person.objects.get(email=sender_email)
self.assertEqual(person, db_person)
def test_empty(self):
email = self._create_email('')
with self.assertRaises(ValueError):
get_or_create_author(email)
def test_invalid_email(self):
# Broken email clients garble email addresses -- #512
from_header = 'testH=?UTF-8?B?w6E=?=user=?UTF-8?B?w6E=?='
email = self._create_email(from_header)
with self.assertRaises(ValueError):
get_or_create_author(email)
def test_ascii_encoding(self):
from_header = 'example user <user@example.com>'
sender_name = 'example user'
sender_email = 'user@example.com'
self._test_encoding(from_header, sender_name, sender_email)
def test_utf8qp_encoding(self):
from_header = '=?utf-8?q?=C3=A9xample=20user?= <user@example.com>'
sender_name = '\xe9xample user'
sender_email = 'user@example.com'
self._test_encoding(from_header, sender_name, sender_email)
def test_utf8qp_split_encoding(self):
from_header = '=?utf-8?q?=C3=A9xample?= user <user@example.com>'
sender_name = '\xe9xample user'
sender_email = 'user@example.com'
self._test_encoding(from_header, sender_name, sender_email)
def test_utf8b64_encoding(self):
from_header = '=?utf-8?B?w6l4YW1wbGUgdXNlcg==?= <user@example.com>'
sender_name = '\xe9xample user'
sender_email = 'user@example.com'
self._test_encoding(from_header, sender_name, sender_email)
class SenderCorrelationTest(TestCase):
"""Validate correct behavior of the get_or_create_author case.
Relies of checking the internal state of a Django model object.
http://stackoverflow.com/a/19379636/613428
"""
@staticmethod
def _create_email(
from_header, reply_tos=None, ccs=None, x_original_from=None
):
mail = 'Message-Id: %s\n' % make_msgid() + 'From: %s\n' % from_header
if reply_tos:
mail += 'Reply-To: %s\n' % ', '.join(reply_tos)
if ccs:
mail += 'Cc: %s\n' % ', '.join(ccs)
if x_original_from:
mail += 'X-Original-From: %s\n' % x_original_from
mail += 'Subject: Tests\n\ntest\n'
return message_from_string(mail)
def test_existing_sender(self):
sender = 'Existing Sender <existing@example.com>'
mail = self._create_email(sender)
# create the person first
person_a = get_or_create_author(mail)
person_a.save()
# then attempt to parse email with the same 'From' line
person_b = get_or_create_author(mail)
self.assertEqual(person_b._state.adding, False)
self.assertEqual(person_b.id, person_a.id)
def test_existing_different_format(self):
sender = 'Existing Sender <existing@example.com>'
mail = self._create_email(sender)
# create the person first
person_a = get_or_create_author(mail)
person_a.save()
# then attempt to parse email with a new 'From' line
mail = self._create_email('existing@example.com')
person_b = get_or_create_author(mail)
self.assertEqual(person_b._state.adding, False)
self.assertEqual(person_b.id, person_a.id)
def test_existing_different_case(self):
sender = 'Existing Sender <existing@example.com>'
mail = self._create_email(sender)
person_a = get_or_create_author(mail)
person_a.save()
mail = self._create_email(sender.upper())
person_b = get_or_create_author(mail)
self.assertEqual(person_b._state.adding, False)
self.assertEqual(person_b.id, person_a.id)
def test_mailman_dmarc_munging(self):
project = create_project()
real_sender = 'Existing Sender <existing@example.com>'
munged_sender = 'Existing Sender via List <{}>'.format(
project.listemail
)
other_email = 'Other Person <other@example.com>'
# Unmunged author
mail = self._create_email(real_sender)
person_a = get_or_create_author(mail, project)
person_a.save()
# Single Reply-To
mail = self._create_email(munged_sender, [real_sender])
person_b = get_or_create_author(mail, project)
self.assertEqual(person_b._state.adding, False)
self.assertEqual(person_b.id, person_a.id)
# Single Cc
mail = self._create_email(munged_sender, [], [real_sender])
person_b = get_or_create_author(mail, project)
self.assertEqual(person_b._state.adding, False)
self.assertEqual(person_b.id, person_a.id)
# Multiple Reply-Tos and Ccs
mail = self._create_email(
munged_sender,
[other_email, real_sender],
[other_email, other_email],
)
person_b = get_or_create_author(mail, project)
self.assertEqual(person_b._state.adding, False)
self.assertEqual(person_b.id, person_a.id)
def test_google_dmarc_munging(self):
project = create_project()
real_sender = 'Existing Sender <existing@example.com>'
munged_sender = "'Existing Sender' via List <{}>".format(
project.listemail
)
# Unmunged author
mail = self._create_email(real_sender)
person_a = get_or_create_author(mail, project)
person_a.save()
# X-Original-From header
mail = self._create_email(munged_sender, None, None, real_sender)
person_b = get_or_create_author(mail, project)
self.assertEqual(person_b._state.adding, False)
self.assertEqual(person_b.id, person_a.id)
def test_weird_dmarc_munging(self):
project = create_project()
real_sender = 'Existing Sender <existing@example.com>'
munged_sender1 = "'Existing Sender' via <{}>".format(project.listemail)
munged_sender2 = "'Existing Sender' <{}>".format(project.listemail)
# Unmunged author
mail = self._create_email(real_sender)
person_a = get_or_create_author(mail, project)
person_a.save()
# Munged with no list name
mail = self._create_email(munged_sender1, None, None, real_sender)
person_b = get_or_create_author(mail, project)
self.assertEqual(person_b._state.adding, False)
self.assertEqual(person_b.id, person_a.id)
# Munged with no 'via'
mail = self._create_email(munged_sender2, None, None, real_sender)
person_b = get_or_create_author(mail, project)
self.assertEqual(person_b._state.adding, False)
self.assertEqual(person_b.id, person_a.id)
class SeriesCorrelationTest(TestCase):
"""Validate correct behavior of find_series."""
@staticmethod
def _create_email(msgid, references=None):
"""Create a sample mail.
Arguments:
msgid (str): The message's msgid
references (list): A list of preceding messages' msgids,
oldest first
"""
mail = (
'Message-Id: %s\n' % msgid
+ 'From: example user <user@example.com>\n'
+ 'Subject: Tests\n'
)
if references:
mail += 'In-Reply-To: %s\n' % references[-1]
mail += 'References: %s\n' % '\n\t'.join(references)
mail += 'test\n\n' + SAMPLE_DIFF
return message_from_string(mail)
def test_new_series(self):
msgid = make_msgid()
email = self._create_email(msgid)
project = create_project()
self.assertFalse(
find_series(project, email, get_or_create_author(email))
)
def test_first_reply(self):
msgid_a = make_msgid()
msgid_b = make_msgid()
email = self._create_email(msgid_b, [msgid_a])
# assume msgid_a was already handled
ref = create_series_reference(msgid=msgid_a)
series = find_series(
ref.series.project, email, get_or_create_author(email)
)
self.assertEqual(series.first(), ref.series)
def test_nested_series(self):
"""Handle a series sent in-reply-to an existing series."""
# create an old series with a "cover letter"
msgids = [make_msgid()]
project = create_project()
series_v1 = create_series(project=project)
create_series_reference(
msgid=msgids[0], series=series_v1, project=project
)
# ...and three patches
for i in range(3):
msgids.append(make_msgid())
create_series_reference(
msgid=msgids[-1], series=series_v1, project=project
)
# now create a new series with "cover letter"
msgids.append(make_msgid())
series_v2 = create_series(project=project)
ref_v2 = create_series_reference(
msgid=msgids[-1], series=series_v2, project=project
)
# ...and the "first patch" of this new series
msgid = make_msgid()
email = self._create_email(msgid, msgids)
series = find_series(project, email, get_or_create_author(email))
# this should link to the second series - not the first
self.assertEqual(len(msgids), 4 + 1) # old series + new cover
self.assertEqual(series.first(), ref_v2.series)
class SubjectEncodingTest(TestCase):
"""Validate correct handling of encoded subjects."""
@staticmethod
def _create_email(subject):
mail = (
'Message-Id: %s\n' % make_msgid()
+ 'From: example user <user@example.com>\n'
+ 'Subject: %s\n\n' % subject
+ 'test\n\n'
+ SAMPLE_DIFF
)
return message_from_string(mail)
def _test_encoding(self, subject_header, parsed_subject):
email = self._create_email(subject_header)
name, _ = clean_subject(email.get('Subject'))
self.assertEqual(name, parsed_subject)
def test_subject_ascii_encoding(self):
subject_header = 'test subject'
subject = 'test subject'
self._test_encoding(subject_header, subject)
def test_subject_utf8qp_encoding(self):
subject_header = '=?utf-8?q?test=20s=c3=bcbject?='
subject = 'test s\xfcbject'
self._test_encoding(subject_header, subject)
def test_subject_utf8qp_multiple_encoding(self):
subject_header = 'test =?utf-8?q?s=c3=bcbject?='
subject = 'test s\xfcbject'
self._test_encoding(subject_header, subject)
class MultipleProjectPatchTest(TestCase):
"""Test that patches sent to multiple patchwork projects are
handled correctly."""
orig_content = 'Test Comment'
patch_filename = '0001-add-line.patch'
msgid = '<1@example.com>'
def setUp(self):
self.p1 = create_project()
self.p2 = create_project()
patch = read_patch(self.patch_filename)
email = create_email(
content=''.join([self.orig_content, '\n', patch]),
msgid=self.msgid,
listid='<%s>' % self.p1.listid,
)
parse_mail(email)
del email['List-ID']
email['List-ID'] = '<%s>' % self.p2.listid
parse_mail(email)
def test_parsed_projects(self):
self.assertEqual(Patch.objects.filter(project=self.p1).count(), 1)
self.assertEqual(Patch.objects.filter(project=self.p2).count(), 1)
class MultipleProjectPatchCommentTest(MultipleProjectPatchTest):
"""Test that followups to multiple-project patches end up on the
correct patch."""
comment_msgid = '<2@example.com>'
comment_content = 'test comment'
def setUp(self):
super(MultipleProjectPatchCommentTest, self).setUp()
for project in [self.p1, self.p2]:
email = create_email(
content=self.comment_content,
msgid=self.comment_msgid,
listid='<%s>' % project.listid,
)
email['In-Reply-To'] = self.msgid
parse_mail(email)
def test_parsed_comment(self):
for project in [self.p1, self.p2]:
patch = Patch.objects.filter(project=project)[0]
# we should see the reply comment only
self.assertEqual(
PatchComment.objects.filter(patch=patch).count(), 1
)
class ListIdHeaderTest(TestCase):
"""Test that we parse List-Id headers from mails correctly."""
def setUp(self):
self.project = create_project()
def test_no_list_id(self):
email = MIMEText('')
project = find_project(email)
self.assertEqual(project, None)
def test_blank_list_id(self):
email = MIMEText('')
email['List-Id'] = ''
project = find_project(email)
self.assertEqual(project, None)
def test_whitespace_list_id(self):
email = MIMEText('')
email['List-Id'] = ' '
project = find_project(email)
self.assertEqual(project, None)
def test_substring_list_id(self):
email = MIMEText('')
email['List-Id'] = 'example.com'
project = find_project(email)
self.assertEqual(project, None)
def test_short_list_id(self):
"""Some mailing lists have List-Id headers in short formats, where it
is only the list ID itself (without enclosing angle-brackets)."""
email = MIMEText('')
email['List-Id'] = self.project.listid
project = find_project(email)
self.assertEqual(project, self.project)
def test_long_list_id(self):
email = MIMEText('')
email['List-Id'] = 'Test text <%s>' % self.project.listid
project = find_project(email)
self.assertEqual(project, self.project)
class PatchParseTest(PatchTest):
"""Test parsing of different patch formats."""
def _test_pull_request_parse(self, mbox_filename):
diff, message = self._find_content(mbox_filename)
pull_url = parse_pull_request(message)
self.assertTrue(diff is None)
self.assertTrue(message is not None)
self.assertTrue(pull_url is not None)
def test_git_pull_request(self):
self._test_pull_request_parse('0001-git-pull-request.mbox')
def test_git_pull_wrapped_request(self):
self._test_pull_request_parse('0002-git-pull-request-wrapped.mbox')
def test_git_pull_git_ssh_url(self):
self._test_pull_request_parse('0004-git-pull-request-git+ssh.mbox')
def test_git_pull_ssh_url(self):
self._test_pull_request_parse('0005-git-pull-request-ssh.mbox')
def test_git_pull_http_url(self):
self._test_pull_request_parse('0006-git-pull-request-http.mbox')
def test_git_pull_git_2_14_3(self):
"""Handle messages from Git 2.14.3+.
See: https://github.com/git/git/commit/e66d7c37a
"""
self._test_pull_request_parse('0017-git-pull-request-git-2-14-3.mbox')
def test_git_pull_with_diff(self):
diff, message = self._find_content(
'0003-git-pull-request-with-diff.mbox'
)
pull_url = parse_pull_request(message)
self.assertEqual(
'git://git.kernel.org/pub/scm/linux/kernel/git/tip/'
'linux-2.6-tip.git x86-fixes-for-linus',
pull_url,
)
self.assertTrue(
diff.startswith('diff --git a/arch/x86/include/asm/smp.h'), diff
)
def test_git_pull_newline_in_url(self):
diff, message = self._find_content(
'0023-git-pull-request-newline-in-url.mbox'
)
pull_url = parse_pull_request(message)
self.assertEqual(
'https://git.kernel.org/pub/scm/linux/kernel/git/matthias.bgg/'
'linux.git/ tags/v5.4-next-soc',
pull_url,
)
def test_git_pull_trailing_space(self):
diff, message = self._find_content(
'0024-git-pull-request-trailing-space.mbox'
)
pull_url = parse_pull_request(message)
self.assertEqual(
'git://git.kernel.org/pub/scm/linux/kernel/git/nsekhar/'
'linux-davinci.git tags/davinci-for-v5.6/soc',
pull_url,
)
def test_git_add_binary_file(self):
diff, message = self._find_content('0025-git-add-binary-file.mbox')
self.assertTrue(diff is not None)
self.assertTrue(message is not None)
self.assertTrue(
diff.startswith('diff --git pixel.bmp pixel.bmp'), diff
)
self.assertIn('GIT binary patch\n', diff)
self.assertIn('literal 142\n', diff)
self.assertIn('literal 0\n', diff)
def test_git_add_mixed_binary_text_files(self):
diff, message = self._find_content(
'0026-git-add-mixed-binary-text-files.mbox'
)
self.assertTrue(diff is not None)
self.assertTrue(message is not None)
self.assertTrue(
diff.startswith('diff --git pixel.bmp pixel.bmp'), diff
)
self.assertIn('GIT binary patch\n', diff)
self.assertIn('diff --git quit.sh quit.sh\n', diff)
def test_git_modify_binary_file(self):
diff, message = self._find_content('0027-git-modify-binary-file.mbox')
self.assertTrue(diff is not None)
self.assertTrue(message is not None)
self.assertTrue(
diff.startswith('diff --git pixel.bmp pixel.bmp'), diff
)
self.assertIn('GIT binary patch\n', diff)
self.assertIn('literal 0\n', diff)
self.assertIn('literal 142\n', diff)
def test_git_rename(self):
diff, _ = self._find_content('0008-git-rename.mbox')
self.assertTrue(diff is not None)
self.assertEqual(diff.count('\nrename from '), 2)
self.assertEqual(diff.count('\nrename to '), 2)
def test_git_rename_with_diff(self):
diff, message = self._find_content('0009-git-rename-with-diff.mbox')
self.assertTrue(diff is not None)
self.assertTrue(message is not None)
self.assertEqual(diff.count('\nrename from '), 2)
self.assertEqual(diff.count('\nrename to '), 2)
self.assertEqual(diff.count('\n-a\n+b'), 1)
def test_git_new_empty_file(self):
diff, message = self._find_content('0021-git-empty-new-file.mbox')
self.assertTrue(diff is not None)
self.assertTrue(message is not None)
def test_git_mode_change(self):
diff, message = self._find_content('0022-git-mode-change.mbox')
self.assertTrue(diff is not None)
self.assertTrue(message is not None)
def test_cvs_format(self):
diff, message = self._find_content('0007-cvs-format-diff.mbox')
self.assertTrue(diff.startswith('Index'))
def test_invalid_charset(self):
"""Validate behavior with an invalid charset name.
Ensure that we can parse with one of the fallback encodings.
"""
diff, message = self._find_content('0010-invalid-charset.mbox')
self.assertTrue(diff is not None)
self.assertTrue(message is not None)
def test_no_newline(self):
"""Validate behavior when trailing newline is absent."""
diff, message = self._find_content(
'0011-no-newline-at-end-of-file.mbox'
)
self.assertTrue(diff is not None)
self.assertTrue(message is not None)
self.assertTrue(
diff.startswith(
'diff --git a/tools/testing/selftests/powerpc/Makefile'
)
)
# Confirm the trailing no newline marker doesn't end up in the comment
self.assertFalse(
message.rstrip().endswith(r'\ No newline at end of file')
)
# Confirm it's instead at the bottom of the patch
self.assertTrue(diff.rstrip().endswith(r'\ No newline at end of file'))
# Confirm we got both markers
self.assertEqual(2, diff.count(r'\ No newline at end of file'))
def test_no_subject(self):
"""Validate parsing a mail with no subject."""
diff, message = self._find_content('0016-no-subject.mbox')
self.assertTrue(diff is not None)
self.assertTrue(message is not None)
def test_html_multipart(self):
"""Validate parsing a mail with multiple parts."""
diff, message = self._find_content('0019-multipart-patch.mbox')
self.assertTrue(diff is not None)
self.assertTrue(message is not None)
self.assertFalse('<div' in diff)
self.assertFalse('<div' in message)
class EncodingParseTest(TestCase):
"""Test parsing of patches with different encoding issues."""
def setUp(self):
self.project = create_project()
def _test_encoded_patch_parse(self, mbox_filename):
mail = read_mail(mbox_filename, self.project)
parse_mail(mail, list_id=self.project.listid)
self.assertEqual(Patch.objects.all().count(), 1)
def test_invalid_header_char(self):
"""Validate behaviour when an invalid character is in a header."""
self._test_encoded_patch_parse('0012-invalid-header-char.mbox')
def test_utf8_mail(self):
"""Validate behaviour when a UTF-8 char is in a message."""
self._test_encoded_patch_parse('0013-with-utf8-body.mbox')
def test_utf8_unencoded_headers(self):
"""Validate behaviour when unencoded UTF-8 is in headers,
including subject and from."""
self._test_encoded_patch_parse('0014-with-unencoded-utf8-headers.mbox')
def test_invalid_utf8_headers(self):
"""Validate behaviour when invalid encoded UTF-8 is in headers."""
self._test_encoded_patch_parse('0015-with-invalid-utf8-headers.mbox')
class CommentParseTest(TestCase):
"""Test parsing of different comment formats."""
@staticmethod
def _find_content(mbox_filename):
mail = read_mail(mbox_filename)
_, message = find_comment_content(mail)
return message
def test_html_multipart(self):
"""Validate parsing a mail with multiple parts."""
message = self._find_content('0020-multipart-comment.mbox')
self.assertTrue(message is not None)
self.assertFalse('<div' in message)
class DelegateRequestTest(TestCase):
patch_filename = '0001-add-line.patch'
msgid = '<1@example.com>'
invalid_delegate_email = 'nobody'
def setUp(self):
self.patch = read_patch(self.patch_filename)
self.user = create_user()
self.project = create_project()
def _get_email(self):
email = create_email(self.patch)
del email['List-ID']
email['List-ID'] = '<' + self.project.listid + '>'
email['Message-Id'] = self.msgid
return email
def assertDelegate(self, delegate): # noqa
query = Patch.objects.filter(project=self.project)
self.assertEqual(query.count(), 1)
self.assertEqual(query[0].delegate, delegate)
def test_delegate(self):
email = self._get_email()
email['X-Patchwork-Delegate'] = self.user.email
parse_mail(email)
self.assertDelegate(self.user)
def test_no_delegate(self):
email = self._get_email()
parse_mail(email)
self.assertDelegate(None)
def test_invalid_delegate(self):
email = self._get_email()
email['X-Patchwork-Delegate'] = self.invalid_delegate_email
parse_mail(email)
self.assertDelegate(None)
class CommentActionRequiredTest(TestCase):
fixtures = ['default_tags']
def setUp(self):
self.project = create_project(listid='test.example.com')
def _create_submission_and_comments(self, submission_email):
comment_a_email = create_email(
'test comment\n',
in_reply_to=submission_email['Message-Id'],
listid=self.project.listid,
headers={},
)
comment_b_email = create_email(
'another test comment\n',
in_reply_to=submission_email['Message-Id'],
listid=self.project.listid,
headers={'X-Patchwork-Action-Required': ''},
)
parse_mail(submission_email)
parse_mail(comment_a_email)
parse_mail(comment_b_email)
comment_a_msgid = comment_a_email.get('Message-ID')
comment_b_msgid = comment_b_email.get('Message-ID')
return comment_a_msgid, comment_b_msgid
def test_patch_comment(self):
body = read_patch('0001-add-line.patch')
patch_email = create_email(body, listid=self.project.listid)
(
comment_a_msgid,
comment_b_msgid,
) = self._create_submission_and_comments(patch_email)
self.assertEqual(1, Patch.objects.count())
self.assertEqual(2, PatchComment.objects.count())
comment_a = PatchComment.objects.get(msgid=comment_a_msgid)
self.assertIsNone(comment_a.addressed)
comment_b = PatchComment.objects.get(msgid=comment_b_msgid)
self.assertFalse(comment_b.addressed)
def test_cover_comment(self):
cover_email = create_email(
'test cover letter',
subject='[0/2] A cover letter',
listid=self.project.listid,
)
(
comment_a_msgid,
comment_b_msgid,
) = self._create_submission_and_comments(cover_email)
self.assertEqual(1, Cover.objects.count())
self.assertEqual(2, CoverComment.objects.count())
comment_a = CoverComment.objects.get(msgid=comment_a_msgid)
self.assertIsNone(comment_a.addressed)
comment_b = CoverComment.objects.get(msgid=comment_b_msgid)
self.assertFalse(comment_b.addressed)
class InitialPatchStateTest(TestCase):
patch_filename = '0001-add-line.patch'
msgid = '<1@example.com>'
invalid_state_name = 'Nonexistent Test State'
def setUp(self):
self.default_state = create_state()
self.nondefault_state = create_state()
self.patch = read_patch(self.patch_filename)
self.user = create_user()
self.project = create_project()