Skip to content

fix: fix issues with openAndWait timeouts#1248

Merged
shadowusr merged 4 commits into
masterfrom
users/shadowusr/TESTPLANE-983.fix-open-and-wait
May 14, 2026
Merged

fix: fix issues with openAndWait timeouts#1248
shadowusr merged 4 commits into
masterfrom
users/shadowusr/TESTPLANE-983.fix-open-and-wait

Conversation

@shadowusr
Copy link
Copy Markdown
Member

What's done?

This PR fixes many issues that openAndWait had with page load timeout handling:

  • it's incorrect to just throw on timeout, because even though client fails fast, browser remains in stuck state and can't handle subsequent commands rendering this "fast fail" pointless
  • improved page load timeout restoration logic
  • bidi required a completely different approach to timeouts handling

Check out related PRs on webdriverio's side:

This PR uses builds based on those branches.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 2, 2026

Open in StackBlitz

npm i https://pkg.pr.new/gemini-testing/testplane@1248

commit: 34c2278

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 133a724ce4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/browser/commands/openAndWait.ts Outdated
@shadowusr shadowusr force-pushed the users/shadowusr/TESTPLANE-983.fix-open-and-wait branch from 0120f3b to 9352aa7 Compare May 14, 2026 21:18
@shadowusr shadowusr force-pushed the users/shadowusr/TESTPLANE-983.fix-open-and-wait branch from aeee292 to 34c2278 Compare May 14, 2026 21:50
@shadowusr shadowusr merged commit 8c0eee7 into master May 14, 2026
7 checks passed
@shadowusr shadowusr deleted the users/shadowusr/TESTPLANE-983.fix-open-and-wait branch May 14, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants